From d348a080f23859860b59c57f1c0495fc781c954d Mon Sep 17 00:00:00 2001 From: Matthieu MOREL Date: Sat, 8 Mar 2025 08:41:10 +0100 Subject: [PATCH] chore: enable thelper and usetesting linters Signed-off-by: Matthieu MOREL --- .golangci.yml | 22 ++++++++++++++++++++++ load/load_test.go | 12 ++++++------ 2 files changed, 28 insertions(+), 6 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index 9229c09..493aacd 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -22,8 +22,10 @@ linters: - predeclared - revive - testifylint + - thelper - typecheck - unparam + - usetesting disable: - errcheck - govet @@ -101,3 +103,23 @@ linters-settings: disabled: true testifylint: enable-all: true + thelper: + test: + # Check t.Helper() begins helper function. + # Default: true + begin: false + benchmark: + # Check b.Helper() begins helper function. + # Default: true + begin: false + tb: + # Check tb.Helper() begins helper function. + # Default: true + begin: false + fuzz: + # Check f.Helper() begins helper function. + # Default: true + begin: false + usetesting: + os-create-temp: false + os-mkdir-temp: false diff --git a/load/load_test.go b/load/load_test.go index 38e032b..d790d21 100644 --- a/load/load_test.go +++ b/load/load_test.go @@ -9,9 +9,9 @@ import ( "github.com/shirou/gopsutil/v4/internal/common" ) -func skipIfNotImplementedErr(t testing.TB, err error) { +func skipIfNotImplementedErr(tb testing.TB, err error) { if errors.Is(err, common.ErrNotImplementedError) { - t.Skip("not implemented") + tb.Skip("not implemented") } } @@ -72,15 +72,15 @@ func TestMiscStatString(t *testing.T) { } func BenchmarkLoad(b *testing.B) { - loadAvg := func(t testing.TB) { + loadAvg := func(tb testing.TB) { v, err := Avg() - skipIfNotImplementedErr(t, err) + skipIfNotImplementedErr(tb, err) if err != nil { - t.Errorf("error %v", err) + tb.Errorf("error %v", err) } empty := &AvgStat{} if v == empty { - t.Errorf("error load: %v", v) + tb.Errorf("error load: %v", v) } }