Commit Graph

61 Commits (92e037d58cc4d2b6e62455d19bfb41fce7bded74)

Author SHA1 Message Date
Matthieu MOREL 8c1a718a5d chore: use testify instead of testing
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Matthieu MOREL d348a080f2
chore: enable thelper and usetesting linters
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Matthieu MOREL 9ce2ec161e chore: enable golangci-lint on Windows and MacOS
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
shirou d725bd1786 fix lint
shirou e9591b5b01 rename redundant test function names, such as TestCPU in cpu package
shirou bc060cc227 add SPDX License, remove old build tag, and replace import
Eric Anderson cded1805c1 Total Processes in `MiscStat` Corrected
The `ProcsTotal` in the `MiscStat` structure was very inaccurate. It was reading
a value which is the total number of kernel scheduling entities. This includes
both processes and threads significantly overcounting.

This instead uses an existing method already in common to count the number of
processes via the /proc filesystem where any directory is a number. This should
still be a single syscall to read that directory entry.

This fixes #1606.
Jan De Dobbeleer ac63a5690e
fix(windows): remove log statement
TossPig 03d43fb5a2
[load][windows] Fix DATA RACE in load. Avg()
fixed #1526
shirou 0665cafa1b chore: replace deprecated ioutil package to os and io
Antoine Toulme 38b94668ea allow to pass context values to override environment variables
shirou 852f455217 fix lint
shirou 231d6f3d4e [load][windows]: add error detail and context handling.
xca1075 b3ab1561bc more aix nocgo implementations
xca1075 d4f012c565 fix aix nocgo compile
xca1075 e24e72062b aix: split code, that uses perfstat, to _cgo and _nocgo files
Ville Skyttä f7e1f36418 refactor: remove unnecessary exec.LookPath calls
Executing the command does the lookup if needed and returns the same
error when not found, no need to do it separately.
Ville Skyttä 1e56c6f421 Spelling and grammar fixes
Ville Skyttä d92d114f90 [load][solaris] implement AvgWithContext
mmorel-35 1e6b445a8a gofumpt
mmorel-35 eb5f6203d8 gofmt
Matthieu MOREL c8fd8c7b1f
enable unparam linter
Matthieu MOREL b673968d5d
enable errorlint linter
shirou d2e27c1712 fix dependabot v2 deletion.
shirou 0969c9436b delete v2 directory, move v3 to top #1078
Ville Skyttä fb0c322260 Check error identity with errors.Is
Ville Skyttä 633e77013f Use short if
Ville Skyttä 803cea9d67 Don't use underscores in variable names
Ville Skyttä 65616500e8 Remove unnecessary empty lines
Ville Skyttä eab3aea46b [load][solaris] support MiscStat.ProcsRunning
Johannes Drummer 82b235c9f5 v2 windows counters on non english systems
Lomanic ebd8102702
Merge pull request #897 from james-bebbington/load-processes-created
AtakanColak 277c95057b tidy up loop control and mutex
AtakanColak b2a3574216 remove percent
AtakanColak fb44aead39 use ticker and explicit contants
AtakanColak 498a39984d tidy comments
AtakanColak 2c98f69e11 add load v2
tidied up common/windows
added load benchmark for load_test
cpu percent is used as load if queue is zero
AtakanColak 24e6d6d350 add load to windows
James Bebbington 79e9a07263 Add ProcsCreated stat for openbsd
Lomanic 78a65a67a9 [load] Skip tests on non-implemented platforms #446
James Bebbington 28b2246b5b Add processes created to misc stats
Aman Gupta f42052bee7 [load][android] implement on top of sysinfo syscall
pytimer 9715668586 add ProcsTotal in load
Lomanic 974d52d412 [load][darwin] Remove calls to sysctl binary in load/load_darwin.go #639
Again, a simple benchmark:

Lomanics-iMac:~ lomanic$ time ./load_avg.old ; time ./load_avg
{load1:0.89,load5:0.99,load15:1.01} <nil>

real    0m0.019s
user    0m0.008s
sys     0m0.013s
{load1:0.8876953125,load5:0.98828125,load15:1.0146484375} <nil>

real    0m0.011s
user    0m0.004s
sys     0m0.006s

This is faster and yields more precise results.
shirou 145dca90f7 change to use CommandContext.
Laurie Clark-Michalek 413cb32b6c Use static initialisation for invoke instances, instead of init funcs
The order of init function execution is dependant on the order that the
source files are passed to the compiler. This causes issues when
building under other build systems, such as bazel or buck, as they are
not guarenteed to maintain the same file order as the default go tool.
shirou 4c73494c78 Add WithContext functions.
Steven Hartland 6450c60b61 Eliminate use of sysctl command on FreeBSD
In order to improve performance and help prevent crashes due to the outstanding fork crash bug:
https://github.com/golang/go/issues/15658

Replace string parsed values from the sysctl command with native reads of sysctl values using unix.SysctlRaw and unix.SysctlUint32.

This also merges OpenBSD and FreeBSD load implementations which are identical.
WAKAYAMA shirou 1ba77cdb3d [load] freebsd: change to use x/sys/unix.SysctlRaw.
This implementation is borrowed from NodeExporter.
https://github.com/prometheus/node_exporter/blob/master/collector/loadavg_freebsd.go
Marco Pfatschbacher b4846b445b Add support for OpenBSD/amd64
This code is based on the FreeBSD version
and implements roughly the same feature set.