gopsutil

Commit Graph

Author	SHA1	Message	Date
Ville Skyttä	b7d717ba80	[process][posix] use os.Lstat for symlink check unix.DT_LNK is not portable; per glibc docs it's a BSD extension. It is not available e.g. in Solaris. https://www.gnu.org/software/libc/manual/html_node/Directory-Entries.html#index-DT_005fLNK As a side effect, fixes incorrect equality comparison against Stat_t.Mode, a bitmask.	4 years ago
Lomanic	0881c11a9a	[process][posix] Fix #1049 check if procfs is mounted before checking if pid exists there Benchmark before this change (process.NewProcess() calls process.PidExistsWithContext() internally) go test -bench=BenchmarkNewProcess github.com/shirou/gopsutil/process goos: linux goarch: amd64 pkg: github.com/shirou/gopsutil/process BenchmarkNewProcess-4 14722 78751 ns/op PASS ok github.com/shirou/gopsutil/process 3.685s Benchmark with this change applied go test -bench=BenchmarkNewProcess github.com/shirou/gopsutil/process goos: linux goarch: amd64 pkg: github.com/shirou/gopsutil/process BenchmarkNewProcess-4 14835 80180 ns/op PASS ok github.com/shirou/gopsutil/process 3.761s	4 years ago
shirou	005a35c436	[v3 migartion] add v3 sourcodes, and change disk.opts to []string	4 years ago

Author

SHA1

Message

Date

Ville Skyttä

b7d717ba80

[process][posix] use os.Lstat for symlink check

unix.DT_LNK is not portable; per glibc docs it's a BSD extension. It is
not available e.g. in Solaris.
https://www.gnu.org/software/libc/manual/html_node/Directory-Entries.html#index-DT_005fLNK

As a side effect, fixes incorrect equality comparison against
Stat_t.Mode, a bitmask.

Lomanic

0881c11a9a

[process][posix] Fix #1049 check if procfs is mounted before checking if pid exists there

Benchmark before this change (process.NewProcess() calls process.PidExistsWithContext()
internally)

    go test -bench=BenchmarkNewProcess github.com/shirou/gopsutil/process
    goos: linux
    goarch: amd64
    pkg: github.com/shirou/gopsutil/process
    BenchmarkNewProcess-4              14722             78751 ns/op
    PASS
    ok      github.com/shirou/gopsutil/process      3.685s

Benchmark with this change applied

    go test -bench=BenchmarkNewProcess github.com/shirou/gopsutil/process
    goos: linux
    goarch: amd64
    pkg: github.com/shirou/gopsutil/process
    BenchmarkNewProcess-4              14835             80180 ns/op
    PASS
    ok      github.com/shirou/gopsutil/process      3.761s

shirou

005a35c436

[v3 migartion] add v3 sourcodes, and change disk.opts to []string

3 Commits (b7d717ba80089c019a3e2bcccc832d95b4eff098)