Commit Graph

419 Commits (e767a0f0f85ae67f68c76d6a29c537ff71392f88)

Author SHA1 Message Date
Jonathan Matthew 27ffa28a0d add support for OpenBSD/riscv64 1 year ago
shirou e912ebde7a
Merge pull request #1580 from jnewmano/patch-1
Windows, read all PIDs if there are more than 1024 PIDs.
1 year ago
Jason Newman 15f7946fcb
Windows, read all pids if there are more than 1024 pids.
Convert bytes read to number of uint32s that were read.
1 year ago
shirou b10acd4894 [host]: add EnableBootTimeCache function 1 year ago
Chris Gianelloni a8418dfd73 feat: use lsof for net_connections on FreeBSD
Use net.ConnectionsPidWithContext on FreeBSD, similarly to how it is done
on Darwin. This uses common.CallLsofWithContext underneath the hood, which
will use lsof under the hood, if available.

Tested on FreeBSD 13.2-RELEASE

Signed-off-by: Chris Gianelloni <wolf31o2@blinklabs.io>
1 year ago
shirou 83427f964f [process][darwin]: skip process.Nice test if darwin on GitHub Action
fix: https://github.com/shirou/gopsutil/issues/1532
1 year ago
Matthieu MOREL c806740b34
ci(lint): ensure io/ioutil replacement (#1525)
* ci(lint): enure ioutil replacement

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update host_solaris.go
* Update process_linux_test.go
* Update net_linux_test.go
* Update net_linux_test.go
* Update process_test.go
* Update process_linux_test.go
* Update process_linux_test.go

---------

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 years ago
shirou 0665cafa1b chore: replace deprecated ioutil package to os and io 2 years ago
shirou febdeab871 chore: change CIRCLECI environment variable to CI. 2 years ago
Antoine Toulme 54c31d884d
Revert "test results"
This reverts commit ae119d36b8.
2 years ago
Antoine Toulme ae119d36b8 test results 2 years ago
Antoine Toulme 6fff1c0e99
proper benchmark 2 years ago
Antoine Toulme ca71a6db3c
lint 2 years ago
Antoine Toulme a48fd71137
Revert "send results"
This reverts commit a7a94986fb.
2 years ago
Antoine Toulme a7a94986fb send results 2 years ago
Antoine Toulme 4bc9e37b0f
faster file read 2 years ago
Lomanic 8b96d2e9e2 [process][posix] Realign process.Name() with python psutil to return same value on python3 scripts processes
e2c79a1 started to blindly set the process name to the full path (instead of the basename) of the cmdline exectuable
if the process name from the process comm was truncated on linux. Python psutil never did that, and this is just wrong
for python (or any executable interpreted script) where the process name is not the interpreter binary but the script
itself.

A new test to check process name value against psutil value is added here, which would hopefully catch any potential
future changes in psutil.

Reverts #542

Fixes #1485
2 years ago
Lomanic c0f3eb1dfb [process] Remove all noisy and useless Test_AllProcesses_X tests
These tests can't fail more than their invidiual counterparts and produce an incredibly verbose output
2 years ago
Antoine Toulme b712e59295 fix more linting reports 2 years ago
Antoine Toulme 38b94668ea allow to pass context values to override environment variables 2 years ago
cui fliter 9aa4e7a744 fix some comments
Signed-off-by: cui fliter <imcusg@gmail.com>
2 years ago
Eng Zer Jun 0439039205
refactor(process): compare error with `errors.Is`
Starting from Go 1.13, `errors.Is` is the preferable way to compare
error equality [1].

[1]: https://go.dev/blog/go1.13-errors

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2 years ago
Matthieu MOREL 1fb1e3e3e6 ci(lint): correct gci linter
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 years ago
Donal Hurley cf25de7460 Add support for getting process exe in FreeBSD 2 years ago
shirou 852f455217 fix lint 2 years ago
Eng Zer Jun 37894e9b28
test: use `T.Setenv` to set env vars in tests
This commit replaces `os.Setenv` with `t.Setenv` in tests. The
environment variable is automatically restored to its original value
when the test and all its subtests complete.

Reference: https://pkg.go.dev/testing#T.Setenv
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2 years ago
Lomanic 980cc82c08 [process][windows] Retrieve process name as basename of executable
We align ourself with psutil
8e4099d9f0/psutil/_pswindows.py (L749-L759)

Benchmarks show vast improvements

    go test -run=BenchmarkProcessName -bench=BenchmarkProcessName ./process
    goos: windows
    goarch: amd64
    pkg: github.com/shirou/gopsutil/v3/process
    cpu: Intel(R) Core(TM) i5-6300U CPU @ 2.40GHz
    BenchmarkProcessName-4               180           6564033 ns/op
    BenchmarkProcessNameViaExe-4       22111             51153 ns/op
    PASS
    ok      github.com/shirou/gopsutil/v3/process   3.914s

Fixes #1368
2 years ago
Lomanic bd4529a7cc [process][windows] Refator a tiny bit is32BitProcess() function to be more idiomatic Go 2 years ago
Brandon Duffany 38064605a8 Fix memory leaks in darwin_cgo 2 years ago
tienthanh1993 6bc339626b
fix(process,windows): compare len(cwd) to an incorrect value
process/process_windows.go#L411 len(cwd) need compare to userProcParams.CurrentDirectoryPathNameLength instead of userProcParams.CurrentDirectoryPathAddress
3 years ago
Tobias Klauser c76712b8da
host, process: delete darwin/386 code
The darwin/386 port was dropped in Go 1.15 and the imported version of
golang.org/x/sys also no longer supports the port. This module requires
at least Go 1.15 per go.mod, so it no longer builds on darwin/386
anyway.
3 years ago
shirou e2ae339eaf fix(process,linux): remove trailing multiple \x00 3 years ago
Lomanic 7501387fc1 [process][windows] Use WaitForSingleObject with a 0 delay in PidExistsWithContext
Reference https://stackoverflow.com/a/6493793

Fixes #1298
3 years ago
Martin Reindl 1d89235f34 host: add support for OpenBSD/armv7 3 years ago
shirou 7de7d48ef6
Merge pull request #1267 from easyops-cn/master
fix(process): fix OpenFilesWithContext panic problem
3 years ago
Ville Skyttä f7e1f36418 refactor: remove unnecessary exec.LookPath calls
Executing the command does the lookup if needed and returns the same
error when not found, no need to do it separately.
3 years ago
paul 3cd259698f fix(process): fix OpenFilesWithContext panic problem 3 years ago
shirou 9a667f1188
Merge pull request #1210 from mmorel-35/master
enable contextcheck linter
3 years ago
Rishabh Arya 0bf4299250 Add support for reading smaps_rollup 3 years ago
Sergey Kozlov 8ae037c8a1 Fix typing issues in createTimeWithContext on Freebsd/i386
Before change:
```
$ GOOS=freebsd GOARCH=386 go build ./process
process\process_freebsd.go:118:26: cannot use k.Start.Sec * 1000 + k.Start.Usec / 1000 (type int32) as type int64 in return argument
```
3 years ago
Matthieu MOREL b0469a470b
Merge branch 'master' into master 3 years ago
Ville Skyttä 1e56c6f421 Spelling and grammar fixes 3 years ago
shirou 50cad0760c
Merge branch 'master' into refactor/parentwithcontext-ppidwithcontext 3 years ago
shirou 34e74aaccb
Merge pull request #1229 from PierreF/darwin-drop-callps-step2
Darwin drop callps step2
3 years ago
Matthieu MOREL 8ba220d241 enable contextcheck linter 3 years ago
Ville Skyttä 0306525d78 [process] implement ParentWithContext using PpidWithContext
Removes need for redundant ParentWithContext implementations. It had led
to it being unsupported on FreeBSD and OpenBSD even though
PpidWithContext was available for them, and different implementations
for getting the parent info used in ParentWithContext and
PpidWithContext on Darwin and Linux.
3 years ago
shirou 35fbe38505 [process][linux] Fix error handling on Children.
If pgrep returns error, `CallPgrepWithContext` always returns empty pids. So this Children always returns ErrorNoChildren. This PR fixes that handling.
3 years ago
Pierre Fersing 43e50e1d7d Reduce call to ps for process package on darwin 3 years ago
Pierre Fersing 60eae48e6a Drop test for Darwin Pids() 3 years ago
Pierre Fersing b9b3dbe67a Avoid ps command and use KProc on MacOS 3 years ago