Make sure that Test_AllProcesses_cmdLine doesn't ignore failures.

process/process_test.go

@@ -751,34 +751,38 @@ func Test_Process_Environ(t *testing.T) {
 
 func Test_AllProcesses_cmdLine(t *testing.T) {
 	procs, err := Processes()
-	if err == nil {
+	skipIfNotImplementedErr(t, err)
-		for _, proc := range procs {
+	if err != nil {
-			var exeName string
+		t.Fatalf("getting processes error %v", err)
-			var cmdLine string
+	}
-
+	for _, proc := range procs {
-			exeName, _ = proc.Exe()
+		var exeName string
-			cmdLine, err = proc.Cmdline()
+		var cmdLine string
-			if err != nil {
+
-				cmdLine = "Error: " + err.Error()
+		exeName, _ = proc.Exe()
-			}
+		cmdLine, err = proc.Cmdline()
-
+		if err != nil {
-			t.Logf("Process #%v: Name: %v / CmdLine: %v\n", proc.Pid, exeName, cmdLine)
+			cmdLine = "Error: " + err.Error()
 		}
+
+		t.Logf("Process #%v: Name: %v / CmdLine: %v\n", proc.Pid, exeName, cmdLine)
 	}
 }
 
 func Test_AllProcesses_environ(t *testing.T) {
 	procs, err := Processes()
-	if err == nil {
+	skipIfNotImplementedErr(t, err)
-		for _, proc := range procs {
+	if err != nil {
-			exeName, _ := proc.Exe()
+		t.Fatalf("getting processes error %v", err)
-			environ, err := proc.Environ()
+	}
-			if err != nil {
+	for _, proc := range procs {
-				environ = []string{"Error: " + err.Error() }
+		exeName, _ := proc.Exe()
-			}
+		environ, err := proc.Environ()
-
+		if err != nil {
-			t.Logf("Process #%v: Name: %v / Environment Variables: %v\n", proc.Pid, exeName, environ)
+			environ = []string{"Error: " + err.Error()}
 		}
+
+		t.Logf("Process #%v: Name: %v / Environment Variables: %v\n", proc.Pid, exeName, environ)
 	}
 }
 

v3/process/process_test.go

@@ -753,34 +753,38 @@ func Test_Process_Environ(t *testing.T) {
 
 func Test_AllProcesses_cmdLine(t *testing.T) {
 	procs, err := Processes()
-	if err == nil {
+	skipIfNotImplementedErr(t, err)
-		for _, proc := range procs {
+	if err != nil {
-			var exeName string
+		t.Fatalf("getting processes error %v", err)
-			var cmdLine string
+	}
-
+	for _, proc := range procs {
-			exeName, _ = proc.Exe()
+		var exeName string
-			cmdLine, err = proc.Cmdline()
+		var cmdLine string
-			if err != nil {
+
-				cmdLine = "Error: " + err.Error()
+		exeName, _ = proc.Exe()
-			}
+		cmdLine, err = proc.Cmdline()
-
+		if err != nil {
-			t.Logf("Process #%v: Name: %v / CmdLine: %v\n", proc.Pid, exeName, cmdLine)
+			cmdLine = "Error: " + err.Error()
 		}
+
+		t.Logf("Process #%v: Name: %v / CmdLine: %v\n", proc.Pid, exeName, cmdLine)
 	}
 }
 
 func Test_AllProcesses_environ(t *testing.T) {
 	procs, err := Processes()
-	if err == nil {
+	skipIfNotImplementedErr(t, err)
-		for _, proc := range procs {
+	if err != nil {
-			exeName, _ := proc.Exe()
+		t.Fatalf("getting processes error %v", err)
-			environ, err := proc.Environ()
+	}
-			if err != nil {
+	for _, proc := range procs {
-				environ = []string{"Error: " + err.Error() }
+		exeName, _ := proc.Exe()
-			}
+		environ, err := proc.Environ()
-
+		if err != nil {
-			t.Logf("Process #%v: Name: %v / Environment Variables: %v\n", proc.Pid, exeName, environ)
+			environ = []string{"Error: " + err.Error()}
 		}
+
+		t.Logf("Process #%v: Name: %v / Environment Variables: %v\n", proc.Pid, exeName, environ)
 	}
 }