Commit Graph

456 Commits (dependabot/go_modules/github.com/tklauser/go-sysconf-0.3.15)

Author SHA1 Message Date
Rishabh Arya 5b1d8ecae7 fix smap parser
Lomanic 995610e109 [process][windows] Fix Nice() test expecting Unix values
Lomanic 5641beec4c [process][darwin] Fix Parent() when lsof returns warnings
Same as #867, the error being:
error strconv.Atoi: parsing "      Output information may be incomplete.": invalid syntax
Lomanic 148a662b06 [process][darwin] Remove Groups() as it's non-functional
Lomanic f810d518bb
Merge pull request #962 from AtakanColak/fix-ppid-race-961
Fix Windows Ppid Cache Race Condition
Antoine Jacoutot 013cd610f5 process: unbreak build on OpenBSD
Match FreeBSD code to prevent:
process_openbsd.go:230:10: cannot use k.Groups (type [16]uint32) as type []int32 in return argument
AtakanColak 13602a3824 fix ppid cache race condition #964
Sergey Vinogradov 065e609cbf Refactor "process" package
* All context-less wrapping functions (the ones without WithContext
suffix) were moved into process.go since they all are the same.
* Call context is now passed to all underlying functions in
*WithContext() functions.
* All common *BSD bits were moved to process_bsd.go.
* Process.Tgid() method lacked a WithContext counterpart, so
Process.TgidWithContext() was added for uniformity.
* NewProcessWithContext() function was added since NewProcess() is
used a lot throughout the module, and there is no way to pass a
context to it.

This is a part of #761 effort.
shirou b94f262e7d
Merge pull request #949 from boogie-byte/vet-target
Add "vet" target to the Makefile
shirou fe68b86b08
Merge pull request #948 from AtakanColak/windows-cache-ppid
Cache Process Parent ID in Windows
Sergey Vinogradov 8ff2ab3187 Add "vet" target to the Makefile
Making the "vet" target will run "go vet ./..." for each supported
GOOS.

Also, some of the warnings produced by go 1.15 vet were mitigated.
Lomanic eaa34817d0 [process] Add benchmarks for New(), Name() Ppid()
run only them with: go test -bench=. -run=xxx github.com/shirou/gopsutil/process
Atakan Çolak 7cc8d3f711 cache ppid in windows
Lomanic 64ba9d03cd [process] Properly test Ppid() against known value
Lomanic c9c40215f5 [process][darwin] Fix #925 properly with unix.SysctlRaw("kern.proc.pid", PID)
Lomanic 8784f48735
Merge pull request #940 from Lomanic/issue985
[process][darwin] Fix #925 remove references to removed const unix.SYS___SYSCTL from x/sys/unix
Lomanic e1082dabb6 [process][darwin] Fix #925 remove references to removed const unix.SYS___SYSCTL from x/sys/unix
More like a workaround, wanted to port process.getKProcWithContext() to use unix.SysctlRaw() to get rid of exec calls to ps
in the same time but didn't have time.
Lomanic 8a625ec054 [host][process][darwin] Go-fmt code from mktypes.sh from #917
Lomanic 2e4fcbb8c4
Merge pull request #917 from amdprophet/darwin-arm64
Add support for Darwin/ARM64
ninedraft 34df4904f6 use cancelable sleep in cpu.PercentWithContext and process.Process.PercentWithContext
Lomanic e1925b853e
Merge pull request #935 from Lomanic/issue900
[linux] Fix #900, skip or fix failing tests in docker
Lomanic 1b3e0c6643 [linux] Fix #900, skip or fix failing tests in docker
TestGetProcInodesAll: create a server so there are some opened inodes
TestUsers: skip if Users is empty, because of an empty /var/run/utmp
Test_Process_Groups: skip if Groups is empty
TestConnectionsMax: skip on CI, not only CircleCI
Lomanic 84afaae670 [host][mem][process][openbsd] Add 386 const and types definitions
Continuation of #721, this type using mktypes.sh that I didn't know at the time.
Weirdly, `go tool cgo -godefs` doesn't produce propery go-fmt-ed code, had to do run go-fmt manually afterwards.
Simon Thoby 04a6f81e9f fix an invalid shift in windows processes name UTF16 conversion
Justin Kolberg 53ffb0cece Add support for Darwin/ARM64
Signed-off-by: Justin Kolberg <amd.prophet@gmail.com>
shirou 7e94bb8bcd
Merge pull request #775 from TakayukiBGoto/add_additional_gids_support
[Process] Implement Groups() to get additional gids.
shirou bbcb80cd3f
Merge pull request #891 from tribes/master
[process][windows] implement suspending and resuming with ntdll library
Tyler Davis 8d28f1b305 Clean up boolean condition
Tyler Davis 9473d01f0f Fix MemoryMaps on ARM
ARM has some tab characters in smaps instead of spaces, hence switching to strings.Fields instead of strings.Split which handles splitting on all whitespace instead of just spaces.
Merwan Ouddane f459195bc0 [process][windows] implement suspending and resuming with ntdll library
Lomanic 8f969117ab [process][darwin][nocgo] Fix #867 iterate on every lines returned by lsof to handle potential warnings
Mauro Leggieri 7783e1d58e Added retrieval of OS platform to determine better a process platform.
Mauro Leggieri 00957cfedc Fixed slow command line retrieval on Windows
JuanLeon Lahoz 426b5148e3 Provide an estimation of Iowait metric per process
Lomanic 27358e8a2f
Merge pull request #840 from devopsext/correct_exit_code_pid_existence
[process][linux] make process.IsRunning() return nil error if process does not exist
Ilya Prudnikov f3598686cb Correct returned error (set to nil) in case process is not exist
shirou a9d510e7e5
Merge pull request #821 from devopsext/process_check_pid_exnistense_fix
Fix check pid existence when running in different process namespace (container)
Ilya Prudnikov 8dec3d81f3 Fix check pid existence when running in different process namespace (container)
Lomanic 1c8ddacaf7 [process][windows] Use win32 API in process.IOCounters() instead of slow WMI call #250
MashaSamoylova 88d9e38aca Change access right in GetProcessTimes call
shirou 61b5bf8cef
Merge branch 'master' into use-x-sys-windows
Dmitri Goutnik 270f6afc22
Add support for freebsd/arm64
Lomanic f586a57353
Merge pull request #796 from Lomanic/issue795
[process][darwin][openbsd][freebsd] Fix #795 don't truncate process names to 16 characters
Lomanic 8e4dde660a [process][darwin] Fix Test_Process_Status and Status returning more than status letter
TakayukiB Goto 7306b38ac6 [Process] Remove Groups() from process_openbsd
Lomanic e7090ba9fc [process] Fix Test_Children test regression because of some other running test
Lomanic 1fcea92f73 [process] Skip if not implemented Test_IsRunning (for openbsd)
Lomanic e4f087a4af [process] Test process.Name() with long names #795
Lomanic 4f0e679e35 [process][darwin][openbsd][freebsd] Fix #795 don't truncate process names to 16 characters
Lomanic e34a731c69 [process] Fix #773 remove data race in NewProcess
Reproduction case https://github.com/shirou/gopsutil/issues/773#issuecomment-554723678
Tobias Klauser a61c905252 Use golang.org/x/windows functions instead of github.com/shirou/w32
All functions used from github.com/shirou/w32 are also available from
golang.org/x/sys/windows which is already used in other places. Convert
the remaining usages to use the functions from x/sys/windows.
TakayukiB Goto 9c6cedb822 [Process] Fix typo
TakayukiB Goto a93796494b [Process] Define the Groups() only once
Laurent Sesques b3cfb9abc3 Revert "[process] Fix #599 cap percent values returned by *Percent() between 0 and 100"
This reverts commit f4e23559a2.
Fixes #755
TakayukiB Goto f55f202e81 [Process] Implement Groups() to get additional gids.
Lomanic 547679f88e [process] Fix #760 implement IsRunning by checking process with same PID has same CreateTime as current process
shirou 84e6215770
Merge pull request #759 from Lomanic/windows-process-connections
[process][windows] Implement Connections() using net.ConnectionsPid()
shirou 56ed89e0cf
Merge pull request #758 from Lomanic/process-cleanup
[process] Propagate context internally on linux and improve tests
Lomanic f5131dc333 [process][windows] Implement Connections() using net.ConnectionsPid()
Lomanic f09ba75b25 [process] Skip tests on non-implemented platforms #446 and fix Kill/Children tests on windows
Lomanic 6f5b1dbee7 [darwin][process] Add cgo implementation of Exe() from PR #243
Original from ppanyukov 4473014098
Lomanic f49203762b [process] Fix Connections() test with goroutines listening/connecting on TCP
Lomanic 36aa63bdd1 [process][linux] Propagate context internally
Lomanic 3eefe64948 [process] Fix #752 sort PIDS returned by process.Pids()
Lomanic 58dc3b28aa [process][windows] Amend last commit, don't wrap err in NumThreads()
Lomanic 9a445d5f6a [process][windows] Use win32 API in process.NumThreads() instead of slow WMI call
Lomanic 3465186bca [process] Fix #729 check process existence in NewProcess()
shirou 3ad4fbbb0c
Merge pull request #715 from Lomanic/issue599process
[process] Fix #599 cap percent values returned by *Percent() between 0 and 100
Lomanic f4e23559a2 [process] Fix #599 cap percent values returned by *Percent() between 0 and 100
Lomanic 4a95469fc9 [process][windows] Fix #607 check pid existence with OpenProcess+GetExitCodeProcess
Reference https://stackoverflow.com/a/600217
Lomanic 4ad0300e1e [process][windows] Remove magic numbers and useless constants
Lomanic 5b15bc623c [process][posix] Fix #607 check pid existence with a signal instead of listing every pids
Reference 0d6b91e916/lockfile_unix.go
shirou 14ba67b0ab
Merge pull request #706 from Lomanic/windows-process-nice
[process][windows] Use win32 API in process.Nice() instead of slow WMI call
Lomanic f036e8b9e8 [process][windows] Deduplicate repeated code in CreateToolhelp32Snapshot related functions
Lomanic 2ac72f1fa1 [process][linux] Fix NewProcess() on Linux
Related to #704.
Don't break previous API where a Process is always returned, fix undefined variable p.
Lomanic 99169acbd8
Merge pull request #704 from josedh/master
preventing file open and bad defer close call
Jose De La O 258343806a Preventing file open and bad defer close. Allocating mem as late as
possible
Lomanic cf9aa4a8ec [process][windows] Use win32 API in process.Nice() instead of slow WMI call
Convert priority classes values to their WMI equivalent for backward
compatiblity.
Lomanic 47323f9ad5 [process][windows] Fix #586 use win32 API in process.Exe() instead of slow WMI call
This is faster by a factor of 100.

References:
5f4287d17f/psutil/_pswindows.py (L221)
921870d540/psutil/_psutil_windows.c (L1211)
921870d540/psutil/_psutil_windows.c (L626)
Tyler Dixon 4e81681ab3 code review
Tyler Dixon a02925055c Remove cycle between process and host packages
gopsutil is a transitive dependency of another project that I am integrating
into an internal build system. We target multiple platforms and as a part
of the build system for the large internal repo, we calculate the build
graph used to determine what targets have changed and need to be build /
tested as a single DAG for all platforms.

gopsutil currently does not form a DAG if linux and any other platform are
considered at the same time. linux is the only platform where the process
package imports the host package.

To remove this cycle, the relevant methods have been moved to internal/common
with the linux build tag and are consumed the host and process packages.
Lomanic 0e0dd767df [process][darwin] Fix #670 remove call to common.Pipeline (prone to race condition)
Also properly parse lsof to get second txt record instead of hoping the 5th line is the right one (wrong data returned for pid 57)
mingrammer 64a995aad4 Refactor with gofmt
Liam Xu 1b525b7c9c Return cpu time format error
Return cpu time format error
Liam Xu f2f18df9db Use Swith to replace if else
Use Swith to replace if else
Xu Lian 6eb4d73bde Fix an indentation issues
Liam Xu b3670f8027 Add hour handling in convertCPUTimes function
This commit add hour handling in convertCPUTimes function.

The time string usually comes from macOS command line:
ps -a -o stime,utime -p <pid>

which could contain hour string.
mingrammer 017c9f9cbc Fix typos
Lomanic 41e774419f
Merge pull request #643 from wcc526/master
Update process_linux.go for Add process ConnectionsMax
wcc526 462e0f6c2f Update process_linux.go for Add process ConnectionsMax
shirou 457f04671d [process] move PageFaultsStat to process.go
shirou 98c84ed30a [process]: move HWM to MemoryInfo
at least FreeBSD and Darwin has HWM.
shirou a33a26bd97
Merge pull request #567 from tagirb/grouped_memorymaps
implement grouped memorymaps output
shirou 48b37fa45e
Merge pull request #616 from nefeli/linux_page_faults
[process][linux] Export process page fault info
chi-chi weng ec5a8b2a50
Add VmHWM
VmHWM: Peak resident set size ("high water mark").

http://man7.org/linux/man-pages/man5/proc.5.html
Lomanic 56acda8a5b [process][openbsd] Fix compilation on OpenBSD
Lomanic 4104adff3e [process][windows] Fix #466 add SeDebugPrivilege to current process
Lomanic a5ace91cce [process][windows] Propagate context internally
Lomanic e5ca4477a1 [process][windows] WIP #586 use win32 API in process.Exe but fallback on WMI
This method only lets a 32bit program get other 32bit processes exe path
and a 64bit program get other 64bit processes exe path, so we fallback to
the slow (but kind of reliable) WMI calls if we can't access to the other
process module.
David Naylor 414c76f159 [process][linux] Export process page fault info
Add a function for retrieving page fault counts from /proc/[pid]/stat on
Linux.
shirou cce2d16538 [process]: add missing argment to process_fallback.
Lomanic 8002bddf3f Merge branch 'master' into issue596
Lomanic 6b539051d2 [process][windows] Use win32 API in process.Children() instead of slow WMI call
The CreateToolhelp32Snapshot+Process32First+Process32Next combo already
iterates over all processes, so it would be inefficient to enumerate all
processes with process.Processes() and then calling p.Ppid() on each of
them: we just use this combo to get all processes and their ppid in a
single iteration.

This is faster by a factor of 25 compared to the previous WMI call.
Lomanic 8ffa453390 #596 Amend last commit, add missing strconv pkg in process_freebsd.go
Lomanic 8ef9b01052 Fix process.Foreground for BSDs, add openbsd implementation
Lomanic 878e0a701b Fix #596 Implement process.Background and process.Foreground functions
shirou 6f5e32dd2f
Merge pull request #584 from Quasilyte/quasilyte/commentedOutCode
cpu,process: remove commented-out code
Iskander Sharipov f3d4342c30 cpu,process: remove commented-out code
Found using https://go-critic.github.io/overview#commentedOutCode-ref
Lomanic e38ea9f318 [process] Don't lose context in ProcessesWithContext() on Windows and Linux
Lomanic 82b8111d04 [process][darwin] Fix #573 use Pids() to get processes in Processes()
Lomanic ef54649286 [windows] Use windows.NewLazySystemDLL to (possibly) prevent DLL hijacking
Might be useless because of https://docs.microsoft.com/en-us/windows/desktop/dlls/dynamic-link-library-search-order#search-order-for-desktop-applications
but better be safe than sorry.

Ref: https://github.com/shirou/gopsutil/issues/570#issuecomment-413951653
Tagir Bakirov 29b3c3719b fix slice indices
Tagir Bakirov 47166d6a81 implement grouped memorymaps output
Sam Zaydel 391d5ecf7d Fix undefined process.Processes when building telegraf on Solaris-based system
Lomanic 6ddbb8c5d8 [process][windows] Reuse Ppid() in Parent(), don't use slow wmi call
Aleksandr Balezin e2c79a1af7 use full cmdline in case of proc renaming
Michal Rostecki 91ac1d66ac process: Check for error objects
shirou 145dca90f7 change to use CommandContext.
shirou 26a4a2f995 [process]: move ErrorNoChildren to platform independent.
Laurie Clark-Michalek 413cb32b6c Use static initialisation for invoke instances, instead of init funcs
The order of init function execution is dependant on the order that the
source files are passed to the compiler. This causes issues when
building under other build systems, such as bazel or buck, as they are
not guarenteed to maintain the same file order as the default go tool.
Michael Schurter b11d0a7942
typo: wich -> which
Ihde 44ef466a5a Resolve issue #492 to reduce CPU overhead associated with fillFromStat
sada 8dd42707e2 windows: fix WithContext functions
set timeout only if parent context doesn't set.
shirou 6a368fb7cd [process]: add ProcessesWithContext.
shirou a97abd3450
Merge branch 'master' into feature/add_context_support
shirou d1fb05a30b Skip some test if CircleCI.
shirou cd61c36c4f
Merge branch 'master' into feature/add_context_support
Nick Kirsch fb24c70d36 Add ErrNotImplementedError for Tgid support.
Nick Kirsch 6c35887d02 Add ErrNotImplementedError to Darwin, FreeBSD, and OpenBSD.
Nick Kirsch 482ca3af6d Parses the tgid field, which is the thread group id (aka user-space process id) on Linux. Returns error on other platforms.
shirou 4c73494c78 Add WithContext functions.
shirou 27389f01ec
Merge pull request #459 from shirou/feature/implements_process_kill_on_windows
[process]windows: implements process.Kill using os/exec
leaf 65598d98cc To prevent hang if wmi.Query hangs, add a context-aware wrapper for it.
WAKAYAMA shirou f5e19d7e16 [process]windows: implements process.Kill using os/exec
Lomanic 00bdebfce7 Use getFromSnapProcess to get process Name and Ppid on Windows instead of slow WMI
Lomanic da12f10f63 Use w32.EnumerateProcesses instead of slower wmi in windows process.Processes()
Lomanic c9a24cf2d0 Handle case in Windows process.Pids() where buffer is too small to handle that many processes returned by w32.EnumProcesses
Lomanic 0314bc81f3 Use w32.EnumProcesses to get pids on Windows in process.Pids()
Sam Kleinman 4d92a03da8 fix cross compiles
tycho garen 08a382b207 make process.processes function public
mlkm b9ab45bcdd Implement Process.Times for Windows
John Liu d28c254aaf Improve performance of finding child processes on Windows
shirou fa0e9fd921 Merge pull request #428 from Leonid99/threads
Implement Threads() in Linux
Leonid Podolny 4269f19b1b process.go: reformat whitespaces to keep gofmt happy
Leonid Podolny 7ee4a4c6ff Fix Threads() signature to better match python original
Leonid Podolny 7ad3836ad3 Implement Threads() for Linux
Kemal Hadimli 826e63acbc Never divide by zero
Kemal Hadimli a3144a6850 Remove parens
Kemal Hadimli 696e1e0123 Fix NaN percentage if process was created too soon
shirou a452de7c73 Merge pull request #346 from phemmer/rlimit-current
add current values to rlimit retrieval
Shirou WAKAYAMA 3aa2ffab12 [process] linux: fix NumFD type inconversion.
Conor Branagan 7b058c7436 Just look at filenames for linux NumFDs call.
In NumFDs we don't care about the contents of the fields, just how many
there are.
WAKAYAMA Shirou 906b00fc23 add features to README. Thank you for all of great contributors!
shirou f6b70e303c Merge pull request #387 from tychoish/windows-data-collection
collect more data on windows
WAKAYAMA Shirou 5329f8ba79 [process] fix Document of CreatTime seconds -> milliseconds
shirou 1da5000996 Merge pull request #402 from chrisroberts/fix-exe-macos
Fix process.Exe() on macOS 10.12
Aditya Choudhary (c) 533161c2ed added funtion for calculation of CPU usage percentage of a process
Chris Roberts 9c998f664a Fix process.Exe() on macOS 10.12
The `lsof` command on macOS < 10.12 always selects the `p` field
when using the `-F` option. On macOS 10.12 the `f` field is also
always selected causing an incorrect result. This modification adds
both options which are always selected to maintain consistency.
Derek Brown a3ae2ed411 Add domain to username (rather than naked username)
tycho garen d522bf5b7e collect more data on windows
Derek Brown 5157f03748 [windows] add implementation for process.Username()
Sean Chittenden cb12fba4f4
windows.Syscall doesn't exist: use syscall.Syscall()
Sean Chittenden 3e79194fe2
windows.EINVAL doesn't exist, only syscall.EINVAL.
Sean Chittenden 635b971c0e
Move from the `syscall` package to the `golang.org/x/sys/{unix,windows}`
Patrick Hemmer 60c32eb847 add current values to rlimit retrieval
Sean Chittenden d0e40ff723
Fix issues reported by golint.
Sean Chittenden 3834908232
Improve Command() handling and signal handling for launched processes.
WAKAYAMA Shirou 30ebb9ca3a rename expected dir to testdata.
tycho garen 22c56d292e close open files
shirou 35c783ec7d Merge pull request #314 from tychoish/fix-ppid-darwin
error earlier on darwin for get parent pid
tycho garen 6110db7ab5 error earlier on darwin for get parent pid
shirou 53c0262e32 Merge pull request #310 from sparrc/go-fmt
run go fmt ./...
Cameron Sparr a213bf5e6d
run go fmt ./...
Sean Chittenden b68f0fdb25
Add native struct support for FreeBSD/arm.
This was ported by hand and not machine generated, but appears to get
software to build.  Material was sourced from the following and a pile
of `grep(1)`:

[1] https://wiki.freebsd.org/EdMaste/ArchitectureSpecifics
[2] https://svnweb.freebsd.org/base/head/sys/sys/user.h?revision=309676&view=markup#l119
Sam Kleinman 488c56586b add platform compatibility
Jorick Caberio c432d48337 fix truncated process name of linux
Vyacheslav Kuznetsov a35c32b028 Commented the constants origin.
Vyacheslav Kuznetsov 4de4e17f06 Added limit constants. Implemented function to parse process limits from /proc.
shirou 93564b3142 Merge pull request #271 from botherder/master
Obtain executable path from macOS process (fix #270)
Marco Pfatschbacher b4846b445b Add support for OpenBSD/amd64
This code is based on the FreeBSD version
and implements roughly the same feature set.
Nex 189b8e6d12 Fixed missing bin and unused stderr
Nex b6a7649aab Error handling
Nex d9b355f75e Added proper piping of commands
Nex dd3cbcc611 Trying remove single quotes
Nex 1534b109ae Fixing pid name
Nex 8c3e7bd255 Casting pid properly
Nex 9659355f49 Checking content
Nex 8bb06aca3d Fixed type casting
Nex 5481d93989 Fixing assignment of vars
Nex 4f7834af25 Added attempt to get exe path from pid
Nex d44bd00182 Added Terminate() for Windows
Thomas Hipp 68ad8d603c
process: make `ClockTicks` arch-independent
The value for `ClockTicks` is defined as `100` by the Linux kernel for
all currently supported architectures in Go. Therefore, there is no need
to define this constant for each architecture separately.

This fixes #260.

Signed-off-by: Thomas Hipp <thomashipp@gmail.com>
Thomas Hipp eb4a57117f
process: determine page sizes via function
Instead of hard-coding the page size for linux systems, use Go's
`Getpagesize` function.

This resolves #258.

Signed-off-by: Thomas Hipp <thipp@suse.de>
shirou 79184fee44 Merge pull request #251 from theothertomelliott/master
Correctly handle long running processes on OSX
shirou a8e24d70f9 Merge pull request #247 from lfittl/fallback-for-unsupported-architectures
Add fallback code for all unsupported operating systems
Tom Elliott 1435987652 Correctly handle long running processes on OSX
The full etime format is dd-hh:mm:ss. Replacing '-' with ':' fixes parsing of this format.
Lukas Fittl da9fa1162b Add fallback code for all unsupported operating systems.
This enables using gopsutil in a codebase that gets built on other OSes
than the ones supported. Instead of a build failure as before, due to
the build tags, gopsutil will now throw an "not implemented" runtime
error.

Fixes #234.
Tom Elliott 3855e7ba0e Implement CreateTime for darwin. Parses elapsed time and converts this to epoch time.
Nick Cabatoff 28640e5d73 fix incorrect names for fields in proc/pid/io
Diptanu Choudhury af4c8608c9 Casting the values of working set and page file to uint64