shirou
abacce2177
[process][linux] add test to parse fillFromStatus
4 years ago
shirou
008b5a41ef
Merge pull request #1060 from heptalium/master
...
Fix fillFromStatusWithContext() on systems with 128 bit signal masks.
4 years ago
Lomanic
c7a38de76e
Merge pull request #1052 from gballet/openbsd-arm-support
...
add support for OpenBSD arm64
4 years ago
Jens Meißner
fc074343f8
[process][linux] Fix fillFromStatusWithContext() on systems with 128 bit signal masks.
4 years ago
shirou
79048ccbfa
Merge pull request #1035 from jblesener/fixmacosspaces
...
Fix spaces on long process names for MacOS
4 years ago
John Blesener
07797b12d3
Make cmdNameWithContext lower-case to avoid exporting it
...
Signed-off-by: John Blesener <jblesener@reactivelabs.com>
4 years ago
Guillaume Ballet
992d17af94
add support for OpenBSD arm64
4 years ago
Lomanic
0881c11a9a
[process][posix] Fix #1049 check if procfs is mounted before checking if pid exists there
...
Benchmark before this change (process.NewProcess() calls process.PidExistsWithContext()
internally)
go test -bench=BenchmarkNewProcess github.com/shirou/gopsutil/process
goos: linux
goarch: amd64
pkg: github.com/shirou/gopsutil/process
BenchmarkNewProcess-4 14722 78751 ns/op
PASS
ok github.com/shirou/gopsutil/process 3.685s
Benchmark with this change applied
go test -bench=BenchmarkNewProcess github.com/shirou/gopsutil/process
goos: linux
goarch: amd64
pkg: github.com/shirou/gopsutil/process
BenchmarkNewProcess-4 14835 80180 ns/op
PASS
ok github.com/shirou/gopsutil/process 3.761s
4 years ago
Lomanic
62d8920abb
[process][windows] Fix #714 call OpenProcess with PROCESS_QUERY_INFORMATION on WinXP
4 years ago
shirou
a5834f48c4
Merge pull request #1033 from eriknordmark/erik-reduce-memory
...
Avoid returning slice into buffer from Readfile
4 years ago
John Blesener
e8b2bea47f
Fix spaces on long process names for MacOS
4 years ago
eriknordmark
0e13743b77
Avoid returning slice into buffer from Readfile
...
Signed-off-by: eriknordmark <erik@zededa.com>
4 years ago
Paweł Zuzelski
17c03b3b2d
Clarify the godoc of the Children function.
...
The previous godoc string was slightly confusing and only described information that can be deduced from the function signature.
4 years ago
shirou
a9a6146c93
[process] fix MemoryInfo comment. remove Swap
...
fixes #1012
4 years ago
Rishabh Arya
5b1d8ecae7
fix smap parser
4 years ago
Lomanic
995610e109
[process][windows] Fix Nice() test expecting Unix values
4 years ago
Lomanic
5641beec4c
[process][darwin] Fix Parent() when lsof returns warnings
...
Same as #867 , the error being:
error strconv.Atoi: parsing " Output information may be incomplete.": invalid syntax
4 years ago
Lomanic
148a662b06
[process][darwin] Remove Groups() as it's non-functional
4 years ago
Lomanic
f810d518bb
Merge pull request #962 from AtakanColak/fix-ppid-race-961
...
Fix Windows Ppid Cache Race Condition
4 years ago
Antoine Jacoutot
013cd610f5
process: unbreak build on OpenBSD
...
Match FreeBSD code to prevent:
process_openbsd.go:230:10: cannot use k.Groups (type [16]uint32) as type []int32 in return argument
4 years ago
AtakanColak
13602a3824
fix ppid cache race condition #964
4 years ago
Sergey Vinogradov
065e609cbf
Refactor "process" package
...
* All context-less wrapping functions (the ones without WithContext
suffix) were moved into process.go since they all are the same.
* Call context is now passed to all underlying functions in
*WithContext() functions.
* All common *BSD bits were moved to process_bsd.go.
* Process.Tgid() method lacked a WithContext counterpart, so
Process.TgidWithContext() was added for uniformity.
* NewProcessWithContext() function was added since NewProcess() is
used a lot throughout the module, and there is no way to pass a
context to it.
This is a part of #761 effort.
4 years ago
shirou
b94f262e7d
Merge pull request #949 from boogie-byte/vet-target
...
Add "vet" target to the Makefile
4 years ago
shirou
fe68b86b08
Merge pull request #948 from AtakanColak/windows-cache-ppid
...
Cache Process Parent ID in Windows
4 years ago
Sergey Vinogradov
8ff2ab3187
Add "vet" target to the Makefile
...
Making the "vet" target will run "go vet ./..." for each supported
GOOS.
Also, some of the warnings produced by go 1.15 vet were mitigated.
4 years ago
Lomanic
eaa34817d0
[process] Add benchmarks for New(), Name() Ppid()
...
run only them with: go test -bench=. -run=xxx github.com/shirou/gopsutil/process
5 years ago
Atakan Çolak
7cc8d3f711
cache ppid in windows
5 years ago
Lomanic
64ba9d03cd
[process] Properly test Ppid() against known value
5 years ago
Lomanic
c9c40215f5
[process][darwin] Fix #925 properly with unix.SysctlRaw("kern.proc.pid", PID)
5 years ago
Lomanic
8784f48735
Merge pull request #940 from Lomanic/issue985
...
[process][darwin] Fix #925 remove references to removed const unix.SYS___SYSCTL from x/sys/unix
5 years ago
Lomanic
e1082dabb6
[process][darwin] Fix #925 remove references to removed const unix.SYS___SYSCTL from x/sys/unix
...
More like a workaround, wanted to port process.getKProcWithContext() to use unix.SysctlRaw() to get rid of exec calls to ps
in the same time but didn't have time.
5 years ago
Lomanic
8a625ec054
[host][process][darwin] Go-fmt code from mktypes.sh from #917
5 years ago
Lomanic
2e4fcbb8c4
Merge pull request #917 from amdprophet/darwin-arm64
...
Add support for Darwin/ARM64
5 years ago
ninedraft
34df4904f6
use cancelable sleep in cpu.PercentWithContext and process.Process.PercentWithContext
5 years ago
Lomanic
e1925b853e
Merge pull request #935 from Lomanic/issue900
...
[linux] Fix #900 , skip or fix failing tests in docker
5 years ago
Lomanic
1b3e0c6643
[linux] Fix #900 , skip or fix failing tests in docker
...
TestGetProcInodesAll: create a server so there are some opened inodes
TestUsers: skip if Users is empty, because of an empty /var/run/utmp
Test_Process_Groups: skip if Groups is empty
TestConnectionsMax: skip on CI, not only CircleCI
5 years ago
Lomanic
84afaae670
[host][mem][process][openbsd] Add 386 const and types definitions
...
Continuation of #721 , this type using mktypes.sh that I didn't know at the time.
Weirdly, `go tool cgo -godefs` doesn't produce propery go-fmt-ed code, had to do run go-fmt manually afterwards.
5 years ago
Simon Thoby
04a6f81e9f
fix an invalid shift in windows processes name UTF16 conversion
5 years ago
Justin Kolberg
53ffb0cece
Add support for Darwin/ARM64
...
Signed-off-by: Justin Kolberg <amd.prophet@gmail.com>
5 years ago
shirou
7e94bb8bcd
Merge pull request #775 from TakayukiBGoto/add_additional_gids_support
...
[Process] Implement Groups() to get additional gids.
5 years ago
shirou
bbcb80cd3f
Merge pull request #891 from tribes/master
...
[process][windows] implement suspending and resuming with ntdll library
5 years ago
Tyler Davis
8d28f1b305
Clean up boolean condition
5 years ago
Tyler Davis
9473d01f0f
Fix MemoryMaps on ARM
...
ARM has some tab characters in smaps instead of spaces, hence switching to strings.Fields instead of strings.Split which handles splitting on all whitespace instead of just spaces.
5 years ago
Merwan Ouddane
f459195bc0
[process][windows] implement suspending and resuming with ntdll library
5 years ago
Lomanic
8f969117ab
[process][darwin][nocgo] Fix #867 iterate on every lines returned by lsof to handle potential warnings
5 years ago
Mauro Leggieri
7783e1d58e
Added retrieval of OS platform to determine better a process platform.
5 years ago
Mauro Leggieri
00957cfedc
Fixed slow command line retrieval on Windows
5 years ago
JuanLeon Lahoz
426b5148e3
Provide an estimation of Iowait metric per process
5 years ago
Lomanic
27358e8a2f
Merge pull request #840 from devopsext/correct_exit_code_pid_existence
...
[process][linux] make process.IsRunning() return nil error if process does not exist
5 years ago
Ilya Prudnikov
f3598686cb
Correct returned error (set to nil) in case process is not exist
5 years ago
shirou
a9d510e7e5
Merge pull request #821 from devopsext/process_check_pid_exnistense_fix
...
Fix check pid existence when running in different process namespace (container)
5 years ago
Ilya Prudnikov
8dec3d81f3
Fix check pid existence when running in different process namespace (container)
5 years ago
Lomanic
1c8ddacaf7
[process][windows] Use win32 API in process.IOCounters() instead of slow WMI call #250
5 years ago
MashaSamoylova
88d9e38aca
Change access right in GetProcessTimes call
5 years ago
shirou
61b5bf8cef
Merge branch 'master' into use-x-sys-windows
5 years ago
Dmitri Goutnik
270f6afc22
Add support for freebsd/arm64
5 years ago
Lomanic
f586a57353
Merge pull request #796 from Lomanic/issue795
...
[process][darwin][openbsd][freebsd] Fix #795 don't truncate process names to 16 characters
5 years ago
Lomanic
8e4dde660a
[process][darwin] Fix Test_Process_Status and Status returning more than status letter
5 years ago
TakayukiB Goto
7306b38ac6
[Process] Remove Groups() from process_openbsd
5 years ago
Lomanic
e7090ba9fc
[process] Fix Test_Children test regression because of some other running test
5 years ago
Lomanic
1fcea92f73
[process] Skip if not implemented Test_IsRunning (for openbsd)
5 years ago
Lomanic
e4f087a4af
[process] Test process.Name() with long names #795
5 years ago
Lomanic
4f0e679e35
[process][darwin][openbsd][freebsd] Fix #795 don't truncate process names to 16 characters
5 years ago
Lomanic
e34a731c69
[process] Fix #773 remove data race in NewProcess
...
Reproduction case https://github.com/shirou/gopsutil/issues/773#issuecomment-554723678
5 years ago
Tobias Klauser
a61c905252
Use golang.org/x/windows functions instead of github.com/shirou/w32
...
All functions used from github.com/shirou/w32 are also available from
golang.org/x/sys/windows which is already used in other places. Convert
the remaining usages to use the functions from x/sys/windows.
5 years ago
TakayukiB Goto
9c6cedb822
[Process] Fix typo
5 years ago
TakayukiB Goto
a93796494b
[Process] Define the Groups() only once
5 years ago
Laurent Sesques
b3cfb9abc3
Revert "[process] Fix #599 cap percent values returned by *Percent() between 0 and 100"
...
This reverts commit f4e23559a2
.
Fixes #755
5 years ago
TakayukiB Goto
f55f202e81
[Process] Implement Groups() to get additional gids.
6 years ago
Lomanic
547679f88e
[process] Fix #760 implement IsRunning by checking process with same PID has same CreateTime as current process
6 years ago
shirou
84e6215770
Merge pull request #759 from Lomanic/windows-process-connections
...
[process][windows] Implement Connections() using net.ConnectionsPid()
6 years ago
shirou
56ed89e0cf
Merge pull request #758 from Lomanic/process-cleanup
...
[process] Propagate context internally on linux and improve tests
6 years ago
Lomanic
f5131dc333
[process][windows] Implement Connections() using net.ConnectionsPid()
6 years ago
Lomanic
f09ba75b25
[process] Skip tests on non-implemented platforms #446 and fix Kill/Children tests on windows
6 years ago
Lomanic
6f5b1dbee7
[darwin][process] Add cgo implementation of Exe() from PR #243
...
Original from ppanyukov 4473014098
6 years ago
Lomanic
f49203762b
[process] Fix Connections() test with goroutines listening/connecting on TCP
6 years ago
Lomanic
36aa63bdd1
[process][linux] Propagate context internally
6 years ago
Lomanic
3eefe64948
[process] Fix #752 sort PIDS returned by process.Pids()
6 years ago
Lomanic
58dc3b28aa
[process][windows] Amend last commit, don't wrap err in NumThreads()
6 years ago
Lomanic
9a445d5f6a
[process][windows] Use win32 API in process.NumThreads() instead of slow WMI call
6 years ago
Lomanic
3465186bca
[process] Fix #729 check process existence in NewProcess()
6 years ago
shirou
3ad4fbbb0c
Merge pull request #715 from Lomanic/issue599process
...
[process] Fix #599 cap percent values returned by *Percent() between 0 and 100
6 years ago
Lomanic
f4e23559a2
[process] Fix #599 cap percent values returned by *Percent() between 0 and 100
6 years ago
Lomanic
4a95469fc9
[process][windows] Fix #607 check pid existence with OpenProcess+GetExitCodeProcess
...
Reference https://stackoverflow.com/a/600217
6 years ago
Lomanic
4ad0300e1e
[process][windows] Remove magic numbers and useless constants
6 years ago
Lomanic
5b15bc623c
[process][posix] Fix #607 check pid existence with a signal instead of listing every pids
...
Reference 0d6b91e916/lockfile_unix.go
6 years ago
shirou
14ba67b0ab
Merge pull request #706 from Lomanic/windows-process-nice
...
[process][windows] Use win32 API in process.Nice() instead of slow WMI call
6 years ago
Lomanic
f036e8b9e8
[process][windows] Deduplicate repeated code in CreateToolhelp32Snapshot related functions
6 years ago
Lomanic
2ac72f1fa1
[process][linux] Fix NewProcess() on Linux
...
Related to #704 .
Don't break previous API where a Process is always returned, fix undefined variable p.
6 years ago
Lomanic
99169acbd8
Merge pull request #704 from josedh/master
...
preventing file open and bad defer close call
6 years ago
Jose De La O
258343806a
Preventing file open and bad defer close. Allocating mem as late as
...
possible
6 years ago
Lomanic
cf9aa4a8ec
[process][windows] Use win32 API in process.Nice() instead of slow WMI call
...
Convert priority classes values to their WMI equivalent for backward
compatiblity.
6 years ago
Lomanic
47323f9ad5
[process][windows] Fix #586 use win32 API in process.Exe() instead of slow WMI call
...
This is faster by a factor of 100.
References:
5f4287d17f/psutil/_pswindows.py (L221)
921870d540/psutil/_psutil_windows.c (L1211)
921870d540/psutil/_psutil_windows.c (L626)
6 years ago
Tyler Dixon
4e81681ab3
code review
6 years ago
Tyler Dixon
a02925055c
Remove cycle between process and host packages
...
gopsutil is a transitive dependency of another project that I am integrating
into an internal build system. We target multiple platforms and as a part
of the build system for the large internal repo, we calculate the build
graph used to determine what targets have changed and need to be build /
tested as a single DAG for all platforms.
gopsutil currently does not form a DAG if linux and any other platform are
considered at the same time. linux is the only platform where the process
package imports the host package.
To remove this cycle, the relevant methods have been moved to internal/common
with the linux build tag and are consumed the host and process packages.
6 years ago
Lomanic
0e0dd767df
[process][darwin] Fix #670 remove call to common.Pipeline (prone to race condition)
...
Also properly parse lsof to get second txt record instead of hoping the 5th line is the right one (wrong data returned for pid 57)
6 years ago
mingrammer
64a995aad4
Refactor with gofmt
6 years ago
Liam Xu
1b525b7c9c
Return cpu time format error
...
Return cpu time format error
6 years ago
Liam Xu
f2f18df9db
Use Swith to replace if else
...
Use Swith to replace if else
6 years ago
Xu Lian
6eb4d73bde
Fix an indentation issues
6 years ago
Liam Xu
b3670f8027
Add hour handling in convertCPUTimes function
...
This commit add hour handling in convertCPUTimes function.
The time string usually comes from macOS command line:
ps -a -o stime,utime -p <pid>
which could contain hour string.
6 years ago
mingrammer
017c9f9cbc
Fix typos
6 years ago
Lomanic
41e774419f
Merge pull request #643 from wcc526/master
...
Update process_linux.go for Add process ConnectionsMax
6 years ago
wcc526
462e0f6c2f
Update process_linux.go for Add process ConnectionsMax
6 years ago
shirou
457f04671d
[process] move PageFaultsStat to process.go
6 years ago
shirou
98c84ed30a
[process]: move HWM to MemoryInfo
...
at least FreeBSD and Darwin has HWM.
6 years ago
shirou
a33a26bd97
Merge pull request #567 from tagirb/grouped_memorymaps
...
implement grouped memorymaps output
6 years ago
shirou
48b37fa45e
Merge pull request #616 from nefeli/linux_page_faults
...
[process][linux] Export process page fault info
6 years ago
chi-chi weng
ec5a8b2a50
Add VmHWM
...
VmHWM: Peak resident set size ("high water mark").
http://man7.org/linux/man-pages/man5/proc.5.html
6 years ago
Lomanic
56acda8a5b
[process][openbsd] Fix compilation on OpenBSD
6 years ago
Lomanic
4104adff3e
[process][windows] Fix #466 add SeDebugPrivilege to current process
6 years ago
Lomanic
a5ace91cce
[process][windows] Propagate context internally
6 years ago
Lomanic
e5ca4477a1
[process][windows] WIP #586 use win32 API in process.Exe but fallback on WMI
...
This method only lets a 32bit program get other 32bit processes exe path
and a 64bit program get other 64bit processes exe path, so we fallback to
the slow (but kind of reliable) WMI calls if we can't access to the other
process module.
6 years ago
David Naylor
414c76f159
[process][linux] Export process page fault info
...
Add a function for retrieving page fault counts from /proc/[pid]/stat on
Linux.
6 years ago
shirou
cce2d16538
[process]: add missing argment to process_fallback.
6 years ago
Lomanic
8002bddf3f
Merge branch 'master' into issue596
6 years ago
Lomanic
6b539051d2
[process][windows] Use win32 API in process.Children() instead of slow WMI call
...
The CreateToolhelp32Snapshot+Process32First+Process32Next combo already
iterates over all processes, so it would be inefficient to enumerate all
processes with process.Processes() and then calling p.Ppid() on each of
them: we just use this combo to get all processes and their ppid in a
single iteration.
This is faster by a factor of 25 compared to the previous WMI call.
6 years ago
Lomanic
8ffa453390
#596 Amend last commit, add missing strconv pkg in process_freebsd.go
6 years ago
Lomanic
8ef9b01052
Fix process.Foreground for BSDs, add openbsd implementation
6 years ago
Lomanic
878e0a701b
Fix #596 Implement process.Background and process.Foreground functions
6 years ago
shirou
6f5e32dd2f
Merge pull request #584 from Quasilyte/quasilyte/commentedOutCode
...
cpu,process: remove commented-out code
7 years ago
Iskander Sharipov
f3d4342c30
cpu,process: remove commented-out code
...
Found using https://go-critic.github.io/overview#commentedOutCode-ref
7 years ago
Lomanic
e38ea9f318
[process] Don't lose context in ProcessesWithContext() on Windows and Linux
7 years ago
Lomanic
82b8111d04
[process][darwin] Fix #573 use Pids() to get processes in Processes()
7 years ago
Lomanic
ef54649286
[windows] Use windows.NewLazySystemDLL to (possibly) prevent DLL hijacking
...
Might be useless because of https://docs.microsoft.com/en-us/windows/desktop/dlls/dynamic-link-library-search-order#search-order-for-desktop-applications
but better be safe than sorry.
Ref: https://github.com/shirou/gopsutil/issues/570#issuecomment-413951653
7 years ago
Tagir Bakirov
29b3c3719b
fix slice indices
7 years ago
Tagir Bakirov
47166d6a81
implement grouped memorymaps output
7 years ago
Sam Zaydel
391d5ecf7d
Fix undefined process.Processes when building telegraf on Solaris-based system
7 years ago
Lomanic
6ddbb8c5d8
[process][windows] Reuse Ppid() in Parent(), don't use slow wmi call
7 years ago
Aleksandr Balezin
e2c79a1af7
use full cmdline in case of proc renaming
7 years ago
Michal Rostecki
91ac1d66ac
process: Check for error objects
7 years ago
shirou
145dca90f7
change to use CommandContext.
7 years ago
shirou
26a4a2f995
[process]: move ErrorNoChildren to platform independent.
7 years ago
Laurie Clark-Michalek
413cb32b6c
Use static initialisation for invoke instances, instead of init funcs
...
The order of init function execution is dependant on the order that the
source files are passed to the compiler. This causes issues when
building under other build systems, such as bazel or buck, as they are
not guarenteed to maintain the same file order as the default go tool.
7 years ago
Michael Schurter
b11d0a7942
typo: wich -> which
7 years ago
Ihde
44ef466a5a
Resolve issue #492 to reduce CPU overhead associated with fillFromStat
7 years ago
sada
8dd42707e2
windows: fix WithContext functions
...
set timeout only if parent context doesn't set.
7 years ago
shirou
6a368fb7cd
[process]: add ProcessesWithContext.
7 years ago
shirou
a97abd3450
Merge branch 'master' into feature/add_context_support
7 years ago
shirou
d1fb05a30b
Skip some test if CircleCI.
7 years ago
shirou
cd61c36c4f
Merge branch 'master' into feature/add_context_support
7 years ago
Nick Kirsch
fb24c70d36
Add ErrNotImplementedError for Tgid support.
7 years ago
Nick Kirsch
6c35887d02
Add ErrNotImplementedError to Darwin, FreeBSD, and OpenBSD.
7 years ago
Nick Kirsch
482ca3af6d
Parses the tgid field, which is the thread group id (aka user-space process id) on Linux. Returns error on other platforms.
7 years ago
shirou
4c73494c78
Add WithContext functions.
7 years ago
shirou
27389f01ec
Merge pull request #459 from shirou/feature/implements_process_kill_on_windows
...
[process]windows: implements process.Kill using os/exec
7 years ago
leaf
65598d98cc
To prevent hang if wmi.Query hangs, add a context-aware wrapper for it.
7 years ago
WAKAYAMA shirou
f5e19d7e16
[process]windows: implements process.Kill using os/exec
7 years ago
Lomanic
00bdebfce7
Use getFromSnapProcess to get process Name and Ppid on Windows instead of slow WMI
7 years ago
Lomanic
da12f10f63
Use w32.EnumerateProcesses instead of slower wmi in windows process.Processes()
7 years ago