Commit Graph

333 Commits (7ea8062810b6e3076ab6c4b40d6f24421e92a889)

Author SHA1 Message Date
Lomanic f036e8b9e8 [process][windows] Deduplicate repeated code in CreateToolhelp32Snapshot related functions 6 years ago
Lomanic 2ac72f1fa1 [process][linux] Fix NewProcess() on Linux
Related to #704.
Don't break previous API where a Process is always returned, fix undefined variable p.
6 years ago
Lomanic 99169acbd8
Merge pull request #704 from josedh/master
preventing file open and bad defer close call
6 years ago
Jose De La O 258343806a Preventing file open and bad defer close. Allocating mem as late as
possible
6 years ago
Lomanic cf9aa4a8ec [process][windows] Use win32 API in process.Nice() instead of slow WMI call
Convert priority classes values to their WMI equivalent for backward
compatiblity.
6 years ago
Lomanic 47323f9ad5 [process][windows] Fix #586 use win32 API in process.Exe() instead of slow WMI call
This is faster by a factor of 100.

References:
5f4287d17f/psutil/_pswindows.py (L221)
921870d540/psutil/_psutil_windows.c (L1211)
921870d540/psutil/_psutil_windows.c (L626)
6 years ago
Tyler Dixon 4e81681ab3 code review 6 years ago
Tyler Dixon a02925055c Remove cycle between process and host packages
gopsutil is a transitive dependency of another project that I am integrating
into an internal build system. We target multiple platforms and as a part
of the build system for the large internal repo, we calculate the build
graph used to determine what targets have changed and need to be build /
tested as a single DAG for all platforms.

gopsutil currently does not form a DAG if linux and any other platform are
considered at the same time. linux is the only platform where the process
package imports the host package.

To remove this cycle, the relevant methods have been moved to internal/common
with the linux build tag and are consumed the host and process packages.
6 years ago
Lomanic 0e0dd767df [process][darwin] Fix #670 remove call to common.Pipeline (prone to race condition)
Also properly parse lsof to get second txt record instead of hoping the 5th line is the right one (wrong data returned for pid 57)
6 years ago
mingrammer 64a995aad4 Refactor with gofmt 6 years ago
Liam Xu 1b525b7c9c Return cpu time format error
Return cpu time format error
6 years ago
Liam Xu f2f18df9db Use Swith to replace if else
Use Swith to replace if else
6 years ago
Xu Lian 6eb4d73bde Fix an indentation issues 6 years ago
Liam Xu b3670f8027 Add hour handling in convertCPUTimes function
This commit add hour handling in convertCPUTimes function.

The time string usually comes from macOS command line:
ps -a -o stime,utime -p <pid>

which could contain hour string.
6 years ago
mingrammer 017c9f9cbc Fix typos 6 years ago
Lomanic 41e774419f
Merge pull request #643 from wcc526/master
Update process_linux.go for Add process ConnectionsMax
6 years ago
wcc526 462e0f6c2f Update process_linux.go for Add process ConnectionsMax 6 years ago
shirou 457f04671d [process] move PageFaultsStat to process.go 6 years ago
shirou 98c84ed30a [process]: move HWM to MemoryInfo
at least FreeBSD and Darwin has HWM.
6 years ago
shirou a33a26bd97
Merge pull request #567 from tagirb/grouped_memorymaps
implement grouped memorymaps output
6 years ago
shirou 48b37fa45e
Merge pull request #616 from nefeli/linux_page_faults
[process][linux] Export process page fault info
6 years ago
chi-chi weng ec5a8b2a50
Add VmHWM
VmHWM: Peak resident set size ("high water mark").

http://man7.org/linux/man-pages/man5/proc.5.html
6 years ago
Lomanic 56acda8a5b [process][openbsd] Fix compilation on OpenBSD 6 years ago
Lomanic 4104adff3e [process][windows] Fix #466 add SeDebugPrivilege to current process 6 years ago
Lomanic a5ace91cce [process][windows] Propagate context internally 6 years ago
Lomanic e5ca4477a1 [process][windows] WIP #586 use win32 API in process.Exe but fallback on WMI
This method only lets a 32bit program get other 32bit processes exe path
and a 64bit program get other 64bit processes exe path, so we fallback to
the slow (but kind of reliable) WMI calls if we can't access to the other
process module.
6 years ago
David Naylor 414c76f159 [process][linux] Export process page fault info
Add a function for retrieving page fault counts from /proc/[pid]/stat on
Linux.
6 years ago
shirou cce2d16538 [process]: add missing argment to process_fallback. 6 years ago
Lomanic 8002bddf3f Merge branch 'master' into issue596 6 years ago
Lomanic 6b539051d2 [process][windows] Use win32 API in process.Children() instead of slow WMI call
The CreateToolhelp32Snapshot+Process32First+Process32Next combo already
iterates over all processes, so it would be inefficient to enumerate all
processes with process.Processes() and then calling p.Ppid() on each of
them: we just use this combo to get all processes and their ppid in a
single iteration.

This is faster by a factor of 25 compared to the previous WMI call.
6 years ago
Lomanic 8ffa453390 #596 Amend last commit, add missing strconv pkg in process_freebsd.go 6 years ago
Lomanic 8ef9b01052 Fix process.Foreground for BSDs, add openbsd implementation 6 years ago
Lomanic 878e0a701b Fix #596 Implement process.Background and process.Foreground functions 6 years ago
shirou 6f5e32dd2f
Merge pull request #584 from Quasilyte/quasilyte/commentedOutCode
cpu,process: remove commented-out code
7 years ago
Iskander Sharipov f3d4342c30 cpu,process: remove commented-out code
Found using https://go-critic.github.io/overview#commentedOutCode-ref
7 years ago
Lomanic e38ea9f318 [process] Don't lose context in ProcessesWithContext() on Windows and Linux 7 years ago
Lomanic 82b8111d04 [process][darwin] Fix #573 use Pids() to get processes in Processes() 7 years ago
Lomanic ef54649286 [windows] Use windows.NewLazySystemDLL to (possibly) prevent DLL hijacking
Might be useless because of https://docs.microsoft.com/en-us/windows/desktop/dlls/dynamic-link-library-search-order#search-order-for-desktop-applications
but better be safe than sorry.

Ref: https://github.com/shirou/gopsutil/issues/570#issuecomment-413951653
7 years ago
Tagir Bakirov 29b3c3719b fix slice indices 7 years ago
Tagir Bakirov 47166d6a81 implement grouped memorymaps output 7 years ago
Sam Zaydel 391d5ecf7d Fix undefined process.Processes when building telegraf on Solaris-based system 7 years ago
Lomanic 6ddbb8c5d8 [process][windows] Reuse Ppid() in Parent(), don't use slow wmi call 7 years ago
Aleksandr Balezin e2c79a1af7 use full cmdline in case of proc renaming 7 years ago
Michal Rostecki 91ac1d66ac process: Check for error objects 7 years ago
shirou 145dca90f7 change to use CommandContext. 7 years ago
shirou 26a4a2f995 [process]: move ErrorNoChildren to platform independent. 7 years ago
Laurie Clark-Michalek 413cb32b6c Use static initialisation for invoke instances, instead of init funcs
The order of init function execution is dependant on the order that the
source files are passed to the compiler. This causes issues when
building under other build systems, such as bazel or buck, as they are
not guarenteed to maintain the same file order as the default go tool.
7 years ago
Michael Schurter b11d0a7942
typo: wich -> which 7 years ago
Ihde 44ef466a5a Resolve issue #492 to reduce CPU overhead associated with fillFromStat 7 years ago
sada 8dd42707e2 windows: fix WithContext functions
set timeout only if parent context doesn't set.
7 years ago
shirou 6a368fb7cd [process]: add ProcessesWithContext. 7 years ago
shirou a97abd3450
Merge branch 'master' into feature/add_context_support 7 years ago
shirou d1fb05a30b Skip some test if CircleCI. 7 years ago
shirou cd61c36c4f
Merge branch 'master' into feature/add_context_support 7 years ago
Nick Kirsch fb24c70d36 Add ErrNotImplementedError for Tgid support. 7 years ago
Nick Kirsch 6c35887d02 Add ErrNotImplementedError to Darwin, FreeBSD, and OpenBSD. 7 years ago
Nick Kirsch 482ca3af6d Parses the tgid field, which is the thread group id (aka user-space process id) on Linux. Returns error on other platforms. 7 years ago
shirou 4c73494c78 Add WithContext functions. 7 years ago
shirou 27389f01ec
Merge pull request #459 from shirou/feature/implements_process_kill_on_windows
[process]windows: implements process.Kill using os/exec
7 years ago
leaf 65598d98cc To prevent hang if wmi.Query hangs, add a context-aware wrapper for it. 7 years ago
WAKAYAMA shirou f5e19d7e16 [process]windows: implements process.Kill using os/exec 7 years ago
Lomanic 00bdebfce7 Use getFromSnapProcess to get process Name and Ppid on Windows instead of slow WMI 7 years ago
Lomanic da12f10f63 Use w32.EnumerateProcesses instead of slower wmi in windows process.Processes() 7 years ago
Lomanic c9a24cf2d0 Handle case in Windows process.Pids() where buffer is too small to handle that many processes returned by w32.EnumProcesses 7 years ago
Lomanic 0314bc81f3 Use w32.EnumProcesses to get pids on Windows in process.Pids() 7 years ago
Sam Kleinman 4d92a03da8 fix cross compiles 7 years ago
tycho garen 08a382b207 make process.processes function public 7 years ago
mlkm b9ab45bcdd Implement Process.Times for Windows 8 years ago
John Liu d28c254aaf Improve performance of finding child processes on Windows 8 years ago
shirou fa0e9fd921 Merge pull request #428 from Leonid99/threads
Implement Threads() in Linux
8 years ago
Leonid Podolny 4269f19b1b process.go: reformat whitespaces to keep gofmt happy 8 years ago
Leonid Podolny 7ee4a4c6ff Fix Threads() signature to better match python original 8 years ago
Leonid Podolny 7ad3836ad3 Implement Threads() for Linux 8 years ago
Kemal Hadimli 826e63acbc Never divide by zero 8 years ago
Kemal Hadimli a3144a6850 Remove parens 8 years ago
Kemal Hadimli 696e1e0123 Fix NaN percentage if process was created too soon 8 years ago
shirou a452de7c73 Merge pull request #346 from phemmer/rlimit-current
add current values to rlimit retrieval
8 years ago
Shirou WAKAYAMA 3aa2ffab12 [process] linux: fix NumFD type inconversion. 8 years ago
Conor Branagan 7b058c7436 Just look at filenames for linux NumFDs call.
In NumFDs we don't care about the contents of the fields, just how many
there are.
8 years ago
WAKAYAMA Shirou 906b00fc23 add features to README. Thank you for all of great contributors! 8 years ago
shirou f6b70e303c Merge pull request #387 from tychoish/windows-data-collection
collect more data on windows
8 years ago
WAKAYAMA Shirou 5329f8ba79 [process] fix Document of CreatTime seconds -> milliseconds 8 years ago
shirou 1da5000996 Merge pull request #402 from chrisroberts/fix-exe-macos
Fix process.Exe() on macOS 10.12
8 years ago
Aditya Choudhary (c) 533161c2ed added funtion for calculation of CPU usage percentage of a process 8 years ago
Chris Roberts 9c998f664a Fix process.Exe() on macOS 10.12
The `lsof` command on macOS < 10.12 always selects the `p` field
when using the `-F` option. On macOS 10.12 the `f` field is also
always selected causing an incorrect result. This modification adds
both options which are always selected to maintain consistency.
8 years ago
Derek Brown a3ae2ed411 Add domain to username (rather than naked username) 8 years ago
tycho garen d522bf5b7e collect more data on windows 8 years ago
Derek Brown 5157f03748 [windows] add implementation for process.Username() 8 years ago
Sean Chittenden cb12fba4f4
windows.Syscall doesn't exist: use syscall.Syscall() 8 years ago
Sean Chittenden 3e79194fe2
windows.EINVAL doesn't exist, only syscall.EINVAL. 8 years ago
Sean Chittenden 635b971c0e
Move from the `syscall` package to the `golang.org/x/sys/{unix,windows}` 8 years ago
Patrick Hemmer 60c32eb847 add current values to rlimit retrieval 8 years ago
Sean Chittenden d0e40ff723
Fix issues reported by golint. 8 years ago
Sean Chittenden 3834908232
Improve Command() handling and signal handling for launched processes. 8 years ago
WAKAYAMA Shirou 30ebb9ca3a rename expected dir to testdata. 8 years ago
tycho garen 22c56d292e close open files 8 years ago
shirou 35c783ec7d Merge pull request #314 from tychoish/fix-ppid-darwin
error earlier on darwin for get parent pid
8 years ago
tycho garen 6110db7ab5 error earlier on darwin for get parent pid 8 years ago
shirou 53c0262e32 Merge pull request #310 from sparrc/go-fmt
run go fmt ./...
8 years ago
Cameron Sparr a213bf5e6d
run go fmt ./... 8 years ago
Sean Chittenden b68f0fdb25
Add native struct support for FreeBSD/arm.
This was ported by hand and not machine generated, but appears to get
software to build.  Material was sourced from the following and a pile
of `grep(1)`:

[1] https://wiki.freebsd.org/EdMaste/ArchitectureSpecifics
[2] https://svnweb.freebsd.org/base/head/sys/sys/user.h?revision=309676&view=markup#l119
8 years ago
Sam Kleinman 488c56586b add platform compatibility 8 years ago
Jorick Caberio c432d48337 fix truncated process name of linux 8 years ago
Vyacheslav Kuznetsov a35c32b028 Commented the constants origin. 8 years ago
Vyacheslav Kuznetsov 4de4e17f06 Added limit constants. Implemented function to parse process limits from /proc. 8 years ago
shirou 93564b3142 Merge pull request #271 from botherder/master
Obtain executable path from macOS process (fix #270)
8 years ago
Marco Pfatschbacher b4846b445b Add support for OpenBSD/amd64
This code is based on the FreeBSD version
and implements roughly the same feature set.
8 years ago
Nex 189b8e6d12 Fixed missing bin and unused stderr 9 years ago
Nex b6a7649aab Error handling 9 years ago
Nex d9b355f75e Added proper piping of commands 9 years ago
Nex dd3cbcc611 Trying remove single quotes 9 years ago
Nex 1534b109ae Fixing pid name 9 years ago
Nex 8c3e7bd255 Casting pid properly 9 years ago
Nex 9659355f49 Checking content 9 years ago
Nex 8bb06aca3d Fixed type casting 9 years ago
Nex 5481d93989 Fixing assignment of vars 9 years ago
Nex 4f7834af25 Added attempt to get exe path from pid 9 years ago
Nex d44bd00182 Added Terminate() for Windows 9 years ago
Thomas Hipp 68ad8d603c
process: make `ClockTicks` arch-independent
The value for `ClockTicks` is defined as `100` by the Linux kernel for
all currently supported architectures in Go. Therefore, there is no need
to define this constant for each architecture separately.

This fixes #260.

Signed-off-by: Thomas Hipp <thomashipp@gmail.com>
9 years ago
Thomas Hipp eb4a57117f
process: determine page sizes via function
Instead of hard-coding the page size for linux systems, use Go's
`Getpagesize` function.

This resolves #258.

Signed-off-by: Thomas Hipp <thipp@suse.de>
9 years ago
shirou 79184fee44 Merge pull request #251 from theothertomelliott/master
Correctly handle long running processes on OSX
9 years ago
shirou a8e24d70f9 Merge pull request #247 from lfittl/fallback-for-unsupported-architectures
Add fallback code for all unsupported operating systems
9 years ago
Tom Elliott 1435987652 Correctly handle long running processes on OSX
The full etime format is dd-hh:mm:ss. Replacing '-' with ':' fixes parsing of this format.
9 years ago
Lukas Fittl da9fa1162b Add fallback code for all unsupported operating systems.
This enables using gopsutil in a codebase that gets built on other OSes
than the ones supported. Instead of a build failure as before, due to
the build tags, gopsutil will now throw an "not implemented" runtime
error.

Fixes #234.
9 years ago
Tom Elliott 3855e7ba0e Implement CreateTime for darwin. Parses elapsed time and converts this to epoch time. 9 years ago
Nick Cabatoff 28640e5d73 fix incorrect names for fields in proc/pid/io 9 years ago
Diptanu Choudhury af4c8608c9 Casting the values of working set and page file to uint64 9 years ago
Shirou WAKAYAMA c916da2502 [process]linux: add linux_arm64.go explicitly 9 years ago
shirou 6e9b0bbb1b Merge pull request #197 from shirou/process/add_memory_windows
Process/add memory windows
9 years ago
Shirou WAKAYAMA 1d461a68b6 [process]linux: porcess was not started. 9 years ago
Shirou WAKAYAMA 57f6aebc7e add Timeout to invoke command and use common.Invoke refs: #201 9 years ago
WAKAYAMA Shirou ba34a3af8c [process]windows: add IO counters and fix CreateTime 9 years ago
WAKAYAMA Shirou 903277ce2f [process]windows: implement process.MemoryInfo (but no swap) 9 years ago
WAKAYAMA shirou a9040e612c [process]freebsd: update 386. 9 years ago
Shirou WAKAYAMA 9ef341037b [process]posix: update process signal document 9 years ago
Shirou WAKAYAMA 860f5a0803 [process]linux: update comment to show godoc.org. 9 years ago
Shirou WAKAYAMA bd1b04fe67 [process]linux: add document to Status. 9 years ago
Shannon Wynter f99d495462 Run goimports before committing... 9 years ago
Shannon Wynter a4387d0c92 emulate original behaviour 9 years ago
Shannon Wynter c903f14189 Remove the requirement to use lsof by using the information provided in status to get the parent pid 9 years ago
Shirou WAKAYAMA bce9212def fix build bugs. 9 years ago
Shirou WAKAYAMA d21ed2b40d search path via exec.LookPath before actual invoke. 9 years ago
Shirou WAKAYAMA 613a8a90e1 fixed by golint. 9 years ago
Shirou WAKAYAMA 944429d994 fixed by errcheck 9 years ago
Shirou WAKAYAMA da89408631 Merge branch 'master' into v2 9 years ago
WAKAYAMA shirou 37d8908841 [process]freebsd: implementes proceess.Nice() 9 years ago
WAKAYAMA shirou 37b6b4051f [process]freebsd: process_freebsd_amd64.go is now generated by cgo godefs. 9 years ago
Shirou WAKAYAMA 15a7edb712 [process]linux: linux process status change to "R" not "Running" see #173 9 years ago
Shirou WAKAYAMA 4bb84648bf JSON representation is renamed to fit Google JSON style, camelCase. 9 years ago
Shirou WAKAYAMA 46ddd57c72 process has NetIOCounters and IOCounters. 9 years ago