Commit Graph

310 Commits (a5834f48c4a30ff89194ae26062b18ff900ff3ac)

Author SHA1 Message Date
Lomanic 1fcea92f73 [process] Skip if not implemented Test_IsRunning (for openbsd)
Lomanic e4f087a4af [process] Test process.Name() with long names #795
Lomanic 4f0e679e35 [process][darwin][openbsd][freebsd] Fix #795 don't truncate process names to 16 characters
Lomanic e34a731c69 [process] Fix #773 remove data race in NewProcess
Reproduction case https://github.com/shirou/gopsutil/issues/773#issuecomment-554723678
Tobias Klauser a61c905252 Use golang.org/x/windows functions instead of github.com/shirou/w32
All functions used from github.com/shirou/w32 are also available from
golang.org/x/sys/windows which is already used in other places. Convert
the remaining usages to use the functions from x/sys/windows.
TakayukiB Goto 9c6cedb822 [Process] Fix typo
TakayukiB Goto a93796494b [Process] Define the Groups() only once
Laurent Sesques b3cfb9abc3 Revert "[process] Fix #599 cap percent values returned by *Percent() between 0 and 100"
This reverts commit f4e23559a2.
Fixes #755
TakayukiB Goto f55f202e81 [Process] Implement Groups() to get additional gids.
Lomanic 547679f88e [process] Fix #760 implement IsRunning by checking process with same PID has same CreateTime as current process
shirou 84e6215770
Merge pull request #759 from Lomanic/windows-process-connections
[process][windows] Implement Connections() using net.ConnectionsPid()
shirou 56ed89e0cf
Merge pull request #758 from Lomanic/process-cleanup
[process] Propagate context internally on linux and improve tests
Lomanic f5131dc333 [process][windows] Implement Connections() using net.ConnectionsPid()
Lomanic f09ba75b25 [process] Skip tests on non-implemented platforms #446 and fix Kill/Children tests on windows
Lomanic 6f5b1dbee7 [darwin][process] Add cgo implementation of Exe() from PR #243
Original from ppanyukov 4473014098
Lomanic f49203762b [process] Fix Connections() test with goroutines listening/connecting on TCP
Lomanic 36aa63bdd1 [process][linux] Propagate context internally
Lomanic 3eefe64948 [process] Fix #752 sort PIDS returned by process.Pids()
Lomanic 58dc3b28aa [process][windows] Amend last commit, don't wrap err in NumThreads()
Lomanic 9a445d5f6a [process][windows] Use win32 API in process.NumThreads() instead of slow WMI call
Lomanic 3465186bca [process] Fix #729 check process existence in NewProcess()
shirou 3ad4fbbb0c
Merge pull request #715 from Lomanic/issue599process
[process] Fix #599 cap percent values returned by *Percent() between 0 and 100
Lomanic f4e23559a2 [process] Fix #599 cap percent values returned by *Percent() between 0 and 100
Lomanic 4a95469fc9 [process][windows] Fix #607 check pid existence with OpenProcess+GetExitCodeProcess
Reference https://stackoverflow.com/a/600217
Lomanic 4ad0300e1e [process][windows] Remove magic numbers and useless constants
Lomanic 5b15bc623c [process][posix] Fix #607 check pid existence with a signal instead of listing every pids
Reference 0d6b91e916/lockfile_unix.go
shirou 14ba67b0ab
Merge pull request #706 from Lomanic/windows-process-nice
[process][windows] Use win32 API in process.Nice() instead of slow WMI call
Lomanic f036e8b9e8 [process][windows] Deduplicate repeated code in CreateToolhelp32Snapshot related functions
Lomanic 2ac72f1fa1 [process][linux] Fix NewProcess() on Linux
Related to #704.
Don't break previous API where a Process is always returned, fix undefined variable p.
Lomanic 99169acbd8
Merge pull request #704 from josedh/master
preventing file open and bad defer close call
Jose De La O 258343806a Preventing file open and bad defer close. Allocating mem as late as
possible
Lomanic cf9aa4a8ec [process][windows] Use win32 API in process.Nice() instead of slow WMI call
Convert priority classes values to their WMI equivalent for backward
compatiblity.
Lomanic 47323f9ad5 [process][windows] Fix #586 use win32 API in process.Exe() instead of slow WMI call
This is faster by a factor of 100.

References:
5f4287d17f/psutil/_pswindows.py (L221)
921870d540/psutil/_psutil_windows.c (L1211)
921870d540/psutil/_psutil_windows.c (L626)
Tyler Dixon 4e81681ab3 code review
Tyler Dixon a02925055c Remove cycle between process and host packages
gopsutil is a transitive dependency of another project that I am integrating
into an internal build system. We target multiple platforms and as a part
of the build system for the large internal repo, we calculate the build
graph used to determine what targets have changed and need to be build /
tested as a single DAG for all platforms.

gopsutil currently does not form a DAG if linux and any other platform are
considered at the same time. linux is the only platform where the process
package imports the host package.

To remove this cycle, the relevant methods have been moved to internal/common
with the linux build tag and are consumed the host and process packages.
Lomanic 0e0dd767df [process][darwin] Fix #670 remove call to common.Pipeline (prone to race condition)
Also properly parse lsof to get second txt record instead of hoping the 5th line is the right one (wrong data returned for pid 57)
mingrammer 64a995aad4 Refactor with gofmt
Liam Xu 1b525b7c9c Return cpu time format error
Return cpu time format error
Liam Xu f2f18df9db Use Swith to replace if else
Use Swith to replace if else
Xu Lian 6eb4d73bde Fix an indentation issues
Liam Xu b3670f8027 Add hour handling in convertCPUTimes function
This commit add hour handling in convertCPUTimes function.

The time string usually comes from macOS command line:
ps -a -o stime,utime -p <pid>

which could contain hour string.
mingrammer 017c9f9cbc Fix typos
Lomanic 41e774419f
Merge pull request #643 from wcc526/master
Update process_linux.go for Add process ConnectionsMax
wcc526 462e0f6c2f Update process_linux.go for Add process ConnectionsMax
shirou 457f04671d [process] move PageFaultsStat to process.go
shirou 98c84ed30a [process]: move HWM to MemoryInfo
at least FreeBSD and Darwin has HWM.
shirou a33a26bd97
Merge pull request #567 from tagirb/grouped_memorymaps
implement grouped memorymaps output
shirou 48b37fa45e
Merge pull request #616 from nefeli/linux_page_faults
[process][linux] Export process page fault info
chi-chi weng ec5a8b2a50
Add VmHWM
VmHWM: Peak resident set size ("high water mark").

http://man7.org/linux/man-pages/man5/proc.5.html
Lomanic 56acda8a5b [process][openbsd] Fix compilation on OpenBSD
Lomanic 4104adff3e [process][windows] Fix #466 add SeDebugPrivilege to current process
Lomanic a5ace91cce [process][windows] Propagate context internally
Lomanic e5ca4477a1 [process][windows] WIP #586 use win32 API in process.Exe but fallback on WMI
This method only lets a 32bit program get other 32bit processes exe path
and a 64bit program get other 64bit processes exe path, so we fallback to
the slow (but kind of reliable) WMI calls if we can't access to the other
process module.
David Naylor 414c76f159 [process][linux] Export process page fault info
Add a function for retrieving page fault counts from /proc/[pid]/stat on
Linux.
shirou cce2d16538 [process]: add missing argment to process_fallback.
Lomanic 8002bddf3f Merge branch 'master' into issue596
Lomanic 6b539051d2 [process][windows] Use win32 API in process.Children() instead of slow WMI call
The CreateToolhelp32Snapshot+Process32First+Process32Next combo already
iterates over all processes, so it would be inefficient to enumerate all
processes with process.Processes() and then calling p.Ppid() on each of
them: we just use this combo to get all processes and their ppid in a
single iteration.

This is faster by a factor of 25 compared to the previous WMI call.
Lomanic 8ffa453390 #596 Amend last commit, add missing strconv pkg in process_freebsd.go
Lomanic 8ef9b01052 Fix process.Foreground for BSDs, add openbsd implementation
Lomanic 878e0a701b Fix #596 Implement process.Background and process.Foreground functions
shirou 6f5e32dd2f
Merge pull request #584 from Quasilyte/quasilyte/commentedOutCode
cpu,process: remove commented-out code
Iskander Sharipov f3d4342c30 cpu,process: remove commented-out code
Found using https://go-critic.github.io/overview#commentedOutCode-ref
Lomanic e38ea9f318 [process] Don't lose context in ProcessesWithContext() on Windows and Linux
Lomanic 82b8111d04 [process][darwin] Fix #573 use Pids() to get processes in Processes()
Lomanic ef54649286 [windows] Use windows.NewLazySystemDLL to (possibly) prevent DLL hijacking
Might be useless because of https://docs.microsoft.com/en-us/windows/desktop/dlls/dynamic-link-library-search-order#search-order-for-desktop-applications
but better be safe than sorry.

Ref: https://github.com/shirou/gopsutil/issues/570#issuecomment-413951653
Tagir Bakirov 29b3c3719b fix slice indices
Tagir Bakirov 47166d6a81 implement grouped memorymaps output
Sam Zaydel 391d5ecf7d Fix undefined process.Processes when building telegraf on Solaris-based system
Lomanic 6ddbb8c5d8 [process][windows] Reuse Ppid() in Parent(), don't use slow wmi call
Aleksandr Balezin e2c79a1af7 use full cmdline in case of proc renaming
Michal Rostecki 91ac1d66ac process: Check for error objects
shirou 145dca90f7 change to use CommandContext.
shirou 26a4a2f995 [process]: move ErrorNoChildren to platform independent.
Laurie Clark-Michalek 413cb32b6c Use static initialisation for invoke instances, instead of init funcs
The order of init function execution is dependant on the order that the
source files are passed to the compiler. This causes issues when
building under other build systems, such as bazel or buck, as they are
not guarenteed to maintain the same file order as the default go tool.
Michael Schurter b11d0a7942
typo: wich -> which
Ihde 44ef466a5a Resolve issue #492 to reduce CPU overhead associated with fillFromStat
sada 8dd42707e2 windows: fix WithContext functions
set timeout only if parent context doesn't set.
shirou 6a368fb7cd [process]: add ProcessesWithContext.
shirou a97abd3450
Merge branch 'master' into feature/add_context_support
shirou d1fb05a30b Skip some test if CircleCI.
shirou cd61c36c4f
Merge branch 'master' into feature/add_context_support
Nick Kirsch fb24c70d36 Add ErrNotImplementedError for Tgid support.
Nick Kirsch 6c35887d02 Add ErrNotImplementedError to Darwin, FreeBSD, and OpenBSD.
Nick Kirsch 482ca3af6d Parses the tgid field, which is the thread group id (aka user-space process id) on Linux. Returns error on other platforms.
shirou 4c73494c78 Add WithContext functions.
shirou 27389f01ec
Merge pull request #459 from shirou/feature/implements_process_kill_on_windows
[process]windows: implements process.Kill using os/exec
leaf 65598d98cc To prevent hang if wmi.Query hangs, add a context-aware wrapper for it.
WAKAYAMA shirou f5e19d7e16 [process]windows: implements process.Kill using os/exec
Lomanic 00bdebfce7 Use getFromSnapProcess to get process Name and Ppid on Windows instead of slow WMI
Lomanic da12f10f63 Use w32.EnumerateProcesses instead of slower wmi in windows process.Processes()
Lomanic c9a24cf2d0 Handle case in Windows process.Pids() where buffer is too small to handle that many processes returned by w32.EnumProcesses
Lomanic 0314bc81f3 Use w32.EnumProcesses to get pids on Windows in process.Pids()
Sam Kleinman 4d92a03da8 fix cross compiles
tycho garen 08a382b207 make process.processes function public
mlkm b9ab45bcdd Implement Process.Times for Windows
John Liu d28c254aaf Improve performance of finding child processes on Windows
shirou fa0e9fd921 Merge pull request #428 from Leonid99/threads
Implement Threads() in Linux
Leonid Podolny 4269f19b1b process.go: reformat whitespaces to keep gofmt happy
Leonid Podolny 7ee4a4c6ff Fix Threads() signature to better match python original
Leonid Podolny 7ad3836ad3 Implement Threads() for Linux