Commit Graph

240 Commits (dd49c3f47f637c5694d714be3be2c214db121ffa)

Author SHA1 Message Date
Lomanic 3465186bca [process] Fix #729 check process existence in NewProcess() 6 years ago
shirou 3ad4fbbb0c
Merge pull request #715 from Lomanic/issue599process
[process] Fix #599 cap percent values returned by *Percent() between 0 and 100
6 years ago
Lomanic f4e23559a2 [process] Fix #599 cap percent values returned by *Percent() between 0 and 100 6 years ago
Lomanic 4a95469fc9 [process][windows] Fix #607 check pid existence with OpenProcess+GetExitCodeProcess
Reference https://stackoverflow.com/a/600217
6 years ago
Lomanic 4ad0300e1e [process][windows] Remove magic numbers and useless constants 6 years ago
Lomanic 5b15bc623c [process][posix] Fix #607 check pid existence with a signal instead of listing every pids
Reference 0d6b91e916/lockfile_unix.go
6 years ago
shirou 14ba67b0ab
Merge pull request #706 from Lomanic/windows-process-nice
[process][windows] Use win32 API in process.Nice() instead of slow WMI call
6 years ago
Lomanic f036e8b9e8 [process][windows] Deduplicate repeated code in CreateToolhelp32Snapshot related functions 6 years ago
Lomanic 2ac72f1fa1 [process][linux] Fix NewProcess() on Linux
Related to #704.
Don't break previous API where a Process is always returned, fix undefined variable p.
6 years ago
Lomanic 99169acbd8
Merge pull request #704 from josedh/master
preventing file open and bad defer close call
6 years ago
Jose De La O 258343806a Preventing file open and bad defer close. Allocating mem as late as
possible
6 years ago
Lomanic cf9aa4a8ec [process][windows] Use win32 API in process.Nice() instead of slow WMI call
Convert priority classes values to their WMI equivalent for backward
compatiblity.
6 years ago
Lomanic 47323f9ad5 [process][windows] Fix #586 use win32 API in process.Exe() instead of slow WMI call
This is faster by a factor of 100.

References:
5f4287d17f/psutil/_pswindows.py (L221)
921870d540/psutil/_psutil_windows.c (L1211)
921870d540/psutil/_psutil_windows.c (L626)
6 years ago
Tyler Dixon 4e81681ab3 code review 6 years ago
Tyler Dixon a02925055c Remove cycle between process and host packages
gopsutil is a transitive dependency of another project that I am integrating
into an internal build system. We target multiple platforms and as a part
of the build system for the large internal repo, we calculate the build
graph used to determine what targets have changed and need to be build /
tested as a single DAG for all platforms.

gopsutil currently does not form a DAG if linux and any other platform are
considered at the same time. linux is the only platform where the process
package imports the host package.

To remove this cycle, the relevant methods have been moved to internal/common
with the linux build tag and are consumed the host and process packages.
6 years ago
Lomanic 0e0dd767df [process][darwin] Fix #670 remove call to common.Pipeline (prone to race condition)
Also properly parse lsof to get second txt record instead of hoping the 5th line is the right one (wrong data returned for pid 57)
6 years ago
mingrammer 64a995aad4 Refactor with gofmt 6 years ago
Liam Xu 1b525b7c9c Return cpu time format error
Return cpu time format error
6 years ago
Liam Xu f2f18df9db Use Swith to replace if else
Use Swith to replace if else
6 years ago
Xu Lian 6eb4d73bde Fix an indentation issues 6 years ago
Liam Xu b3670f8027 Add hour handling in convertCPUTimes function
This commit add hour handling in convertCPUTimes function.

The time string usually comes from macOS command line:
ps -a -o stime,utime -p <pid>

which could contain hour string.
6 years ago
mingrammer 017c9f9cbc Fix typos 6 years ago
Lomanic 41e774419f
Merge pull request #643 from wcc526/master
Update process_linux.go for Add process ConnectionsMax
6 years ago
wcc526 462e0f6c2f Update process_linux.go for Add process ConnectionsMax 6 years ago
shirou 457f04671d [process] move PageFaultsStat to process.go 6 years ago
shirou 98c84ed30a [process]: move HWM to MemoryInfo
at least FreeBSD and Darwin has HWM.
6 years ago
shirou a33a26bd97
Merge pull request #567 from tagirb/grouped_memorymaps
implement grouped memorymaps output
6 years ago
shirou 48b37fa45e
Merge pull request #616 from nefeli/linux_page_faults
[process][linux] Export process page fault info
6 years ago
chi-chi weng ec5a8b2a50
Add VmHWM
VmHWM: Peak resident set size ("high water mark").

http://man7.org/linux/man-pages/man5/proc.5.html
6 years ago
Lomanic 56acda8a5b [process][openbsd] Fix compilation on OpenBSD 6 years ago
Lomanic 4104adff3e [process][windows] Fix #466 add SeDebugPrivilege to current process 6 years ago
Lomanic a5ace91cce [process][windows] Propagate context internally 6 years ago
Lomanic e5ca4477a1 [process][windows] WIP #586 use win32 API in process.Exe but fallback on WMI
This method only lets a 32bit program get other 32bit processes exe path
and a 64bit program get other 64bit processes exe path, so we fallback to
the slow (but kind of reliable) WMI calls if we can't access to the other
process module.
6 years ago
David Naylor 414c76f159 [process][linux] Export process page fault info
Add a function for retrieving page fault counts from /proc/[pid]/stat on
Linux.
6 years ago
shirou cce2d16538 [process]: add missing argment to process_fallback. 6 years ago
Lomanic 8002bddf3f Merge branch 'master' into issue596 6 years ago
Lomanic 6b539051d2 [process][windows] Use win32 API in process.Children() instead of slow WMI call
The CreateToolhelp32Snapshot+Process32First+Process32Next combo already
iterates over all processes, so it would be inefficient to enumerate all
processes with process.Processes() and then calling p.Ppid() on each of
them: we just use this combo to get all processes and their ppid in a
single iteration.

This is faster by a factor of 25 compared to the previous WMI call.
6 years ago
Lomanic 8ffa453390 #596 Amend last commit, add missing strconv pkg in process_freebsd.go 6 years ago
Lomanic 8ef9b01052 Fix process.Foreground for BSDs, add openbsd implementation 6 years ago
Lomanic 878e0a701b Fix #596 Implement process.Background and process.Foreground functions 6 years ago
shirou 6f5e32dd2f
Merge pull request #584 from Quasilyte/quasilyte/commentedOutCode
cpu,process: remove commented-out code
7 years ago
Iskander Sharipov f3d4342c30 cpu,process: remove commented-out code
Found using https://go-critic.github.io/overview#commentedOutCode-ref
7 years ago
Lomanic e38ea9f318 [process] Don't lose context in ProcessesWithContext() on Windows and Linux 7 years ago
Lomanic 82b8111d04 [process][darwin] Fix #573 use Pids() to get processes in Processes() 7 years ago
Lomanic ef54649286 [windows] Use windows.NewLazySystemDLL to (possibly) prevent DLL hijacking
Might be useless because of https://docs.microsoft.com/en-us/windows/desktop/dlls/dynamic-link-library-search-order#search-order-for-desktop-applications
but better be safe than sorry.

Ref: https://github.com/shirou/gopsutil/issues/570#issuecomment-413951653
7 years ago
Tagir Bakirov 29b3c3719b fix slice indices 7 years ago
Tagir Bakirov 47166d6a81 implement grouped memorymaps output 7 years ago
Sam Zaydel 391d5ecf7d Fix undefined process.Processes when building telegraf on Solaris-based system 7 years ago
Lomanic 6ddbb8c5d8 [process][windows] Reuse Ppid() in Parent(), don't use slow wmi call 7 years ago
Aleksandr Balezin e2c79a1af7 use full cmdline in case of proc renaming 7 years ago